Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for uploading crash reports to Sentry #2605

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Add support for uploading crash reports to Sentry #2605

merged 13 commits into from
Apr 18, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Apr 11, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1205862129634403/f

Description:
Reuse existing DMG app crash reporting UI to upload crash reports from the App Store app.

Steps to test this PR:

  1. Install "DuckDuckGo Sandbox Review" version 1.83.0 (161) from TestFlight.
  2. Run the app, go to Main Menu -> Debug -> Trigger Fatal Error.
  3. Restart the app.
  4. Verify that you're prompted to upload the crash report to DuckDuckGo.
  5. Verify that the crash report appears in Sentry.
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy self-assigned this Apr 11, 2024
@ayoy ayoy mentioned this pull request Apr 11, 2024
Merged
6 tasks
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 11, 2024
@ayoy ayoy removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 11, 2024
ayoy
ayoy commented Apr 12, 2024
View reviewed changes
DuckDuckGo/CrashReports/Model/CrashReportSender.swift
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to BSK

@ayoy ayoy requested a review from samsymons April 12, 2024 14:25
@ayoy ayoy assigned samsymons and unassigned ayoy Apr 12, 2024
@ayoy ayoy marked this pull request as ready for review April 12, 2024 14:25
samsymons
samsymons approved these changes Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't find any issues during testing and the diff looks good. Confirmed that the crash made it up to Sentry as expected.

@ayoy ayoy merged commit 2353201 into main Apr 18, 2024
16 checks passed
@ayoy ayoy deleted the dominik/sentry-appstore branch April 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees

@samsymons samsymons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @samsymons