Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phishing Detection Feature Preferences View #3196

Closed
wants to merge 28 commits into from
Closed

Phishing Detection Feature Preferences View #3196

wants to merge 28 commits into from

Conversation

not-a-rootkit
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208149630394246/f
Tech Design URL: https://app.asana.com/0/481882893211075/1207220724600204/f
CC:

Description:
Implement GeneralPreferencesView for Phishing Detection Error Page. Also add feature flag for enabling/disabling the preferences view.

Steps to test this PR:

  1. Go to Settings>General
  2. Check there is a Malicious Site Protection section
  3. Turn it off
  4. Visit privacy-test-pages.site/security/badware/phishing.html
  5. Check error page is not shown
  6. Turn it back on
  7. Retest, ensure the error page is shown

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@not-a-rootkit
Add phishing detection data, preferences + state
e467e1c
@not-a-rootkit
Add detection preferences
6db217f
@not-a-rootkit
Add phishing detection to special error page tab extension.
c03349a
@not-a-rootkit
Add PhishingDetection folder.
14f8458
@not-a-rootkit
Add URLTokenValidator
d1124ff
@not-a-rootkit
Ensure phishing flagged sites aren't added to history
ce2983d
@not-a-rootkit
Add redirect to duck://error on phishing detected
047f5bb
@not-a-rootkit
Update PrivacyInfo.isPhishing when phishing detected
250dc18
@not-a-rootkit
Add DuckURLSchemeHandler for phishing error page
e4059c7
@not-a-rootkit
Load SpecialErrorPage HTML in loadErrorHTML
47d0c7c
@not-a-rootkit
Update phishingErrorData for UserScript
af65c25
@not-a-rootkit
Add error page tab title
9d6f0e3
@not-a-rootkit
Update favicon + tab title in TabViewModel
60138d3
@not-a-rootkit
Add alert-red colors (as defined in ship review)
c9a9683
@not-a-rootkit
Update address bar buttons when phishing error page clicked through.
6d4a843
@not-a-rootkit
Add preferences UserText
0f81e17
@not-a-rootkit
Add phishingDetectionPreferences + rename feature flag for error page.
f157561
@not-a-rootkit
Add preferences localizables.
28e8c95
@not-a-rootkit
Rename phishingDetectionErrorPage feature flag.
2b37d16
@not-a-rootkit
Add Preferences Views.
215a8ba
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against f42f072

Base automatically changed from tespach/phishing-privacy-dashboard to tespach/phishing-detection-integration September 5, 2024 14:12
@not-a-rootkit not-a-rootkit deleted the tespach/phishing-detection-settings branch September 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@not-a-rootkit