Phishing Detection Feature Preferences View

DuckDuckGo/Common/Localizables/UserText.swift

@@ -412,6 +412,10 @@ struct UserText {
 
     static let downloadsOpenPopupOnCompletion = NSLocalizedString("downloads.open.on.completion", value: "Automatically open the Downloads panel when downloads complete", comment: "Checkbox to open a Download Manager popover when downloads are completed")
 
+    static let phishingDetectionHeader = NSLocalizedString("phishing-detection.enabled.header", value: "Malicious Site Protection", comment: "Header for phishing site protection section in the settings page")
+    static let phishingDetectionIsEnabled = NSLocalizedString("phishing-detection.enabled.checkbox", value: "Allow DuckDuckGo to warn you before loading a webpage that has been flagged as malicious or fraudulent.", comment: "Checkbox that enables or disables the phishing detection feature in the browser")
+    static let phishingDetectionEnabledWarning = NSLocalizedString("phishing-detection.enabled.warning", value: "Disabling this feature can put your personal information at risk. Only do so if you fully understand the risk involved.", comment: "A description box to warn users away from disabling phishing protection")
+
     // MARK: Password Manager
     static let passwordManagementAllItems = NSLocalizedString("passsword.management.all-items", value: "All Items", comment: "Used as title for the Autofill All Items option")
     static let passwordManagementLogins = NSLocalizedString("passsword.management.logins", value: "Passwords", comment: "Used as title for the Autofill Logins option")

DuckDuckGo/FeatureFlagging/Model/FeatureFlag.swift

@@ -22,7 +22,8 @@ import BrowserServicesKit
 public enum FeatureFlag: String {
     case debugMenu
     case sslCertificatesBypass
-    case phishingDetection
+    case phishingDetectionErrorPage
+    case phishingDetectionPreferences
 
     /// Add experimental atb parameter to SERP queries for internal users to display Privacy Reminder
     /// https://app.asana.com/0/1199230911884351/1205979030848528/f
@@ -53,8 +54,10 @@ extension FeatureFlag: FeatureFlagSourceProviding {
             return .remoteReleasable(.subfeature(AutofillSubfeature.unknownUsernameCategorization))
         case .freemiumPIR:
             return .remoteDevelopment(.subfeature(DBPSubfeature.freemium))
-        case .phishingDetection:
+        case .phishingDetectionErrorPage:
             return .remoteReleasable(.subfeature(PhishingDetectionSubfeature.allowErrorPage))
+        case .phishingDetectionPreferences:
+            return .remoteReleasable(.subfeature(PhishingDetectionSubfeature.allowPreferencesToggle))
         }
     }
 }

DuckDuckGo/Localizable.xcstrings

@@ -41242,6 +41242,42 @@
         }
       }
     },
+    "phishing-detection.enabled.checkbox" : {
+      "comment" : "Checkbox that enables or disables the phishing detection feature in the browser",
+      "extractionState" : "extracted_with_value",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "Allow DuckDuckGo to warn you before loading a webpage that has been flagged as malicious or fraudulent."
+          }
+        }
+      }
+    },
+    "phishing-detection.enabled.header" : {
+      "comment" : "Header for phishing site protection section in the settings page",
+      "extractionState" : "extracted_with_value",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "Malicious Site Protection"
+          }
+        }
+      }
+    },
+    "phishing-detection.enabled.warning" : {
+      "comment" : "A description box to warn users away from disabling phishing protection",
+      "extractionState" : "extracted_with_value",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "Disabling this feature can put your personal information at risk. Only do so if you fully understand the risk involved."
+          }
+        }
+      }
+    },
     "phishing.error.page.tab.title" : {
       "comment" : "Title shown in an error page tab that warn users of security risks on a website that has been flagged as malicious.",
       "extractionState" : "extracted_with_value",

DuckDuckGo/PhishingDetection/PhishingDetection.swift

@@ -135,7 +135,7 @@ public class PhishingDetection: PhishingSiteDetecting {
     }
 
     private func startUpdateTasksIfEnabled() {
-        if featureFlagger.isFeatureOn(.phishingDetection),
+        if featureFlagger.isFeatureOn(.phishingDetectionErrorPage),
            self.detectionPreferences.isEnabled {
             startUpdateTasks()
         }

DuckDuckGo/Preferences/View/PreferencesGeneralView.swift

@@ -31,9 +31,11 @@ extension Preferences {
         @ObservedObject var searchModel: SearchPreferences
         @ObservedObject var tabsModel: TabsPreferences
         @ObservedObject var dataClearingModel: DataClearingPreferences
+        @ObservedObject var phishingDetectionModel: PhishingDetectionPreferences
         @State private var showingCustomHomePageSheet = false
         @State private var isAddedToDock = false
         var dockCustomizer: DockCustomizer
+        let featureFlagger = NSApp.delegateTyped.featureFlagger
 
         var body: some View {
             PreferencePane(UserText.general) {
@@ -190,6 +192,20 @@ extension Preferences {
                                        isOn: $downloadsModel.alwaysRequestDownloadLocation)
                     }
                 }
+
+                // SECTION 7: Phishing Detection
+                if featureFlagger.isFeatureOn(.phishingDetectionPreferences) {
+                    PreferencePaneSection(UserText.phishingDetectionHeader) {
+                        PreferencePaneSubSection {
+                            ToggleMenuItem(UserText.phishingDetectionIsEnabled,
+                                           isOn: $phishingDetectionModel.isEnabled)
+                        }.padding(.bottom, 5)
+                        Text(UserText.phishingDetectionEnabledWarning)
+                            .font(.footnote)
+                            .foregroundColor(.red)
+                            .padding(.top, 5)
+                    }
+                }
             }
         }
     }

DuckDuckGo/Preferences/View/PreferencesRootView.swift

@@ -94,7 +94,7 @@ enum Preferences {
                                 searchModel: SearchPreferences.shared,
                                 tabsModel: TabsPreferences.shared,
                                 dataClearingModel: DataClearingPreferences.shared,
-                                dockCustomizer: DockCustomizer())
+                                phishingDetectionModel: PhishingDetectionPreferences.shared, dockCustomizer: DockCustomizer())
                 case .sync:
                     SyncView()
                 case .appearance: