Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to autofill DAU reporting for iOS credential provider extension #3763

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jan 22, 2025

Task/Issue URL: https://app.asana.com/0/1201462886803403/1208980858161408/f
Tech Design URL:
CC:

Description:
Minor update to support BSK change to AutofillPixelReporter

Steps to test this PR:
Regression testing to confirm there are no changes on macOS

  1. Launching the app from main, reset Autofill Data via the debug menu if the app has already been used today
  2. Perform a search in the address bar
  3. Save a credential e.g. for https://autofill.me/form/login-simple but do not fill the saved credential
  4. Launch the app from this branch
  5. Fill the credential saved in step 3
  6. Confirm the pixel m.autofill.activeuser is fired

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

…on-ios-daus

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 changed the title Anya/autofill extension ios daus Update to autofill DAU reporting for iOS credential provider extension Jan 22, 2025
…on-ios-daus

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 requested a review from graeme January 23, 2025 20:26
…on-ios-daus

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant