Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to autofill DAU reporting for iOS credential provider extension #3763

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+7 −6
Open

Update to autofill DAU reporting for iOS credential provider extension #3763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a2c6504
Set BSK commit
amddg44 Jan 22, 2025
282b04c
Update to support app group changes for iOS
amddg44 Jan 22, 2025
3df5c79
Merge remote-tracking branch 'origin/main' into anya/autofill-extensi…
amddg44 Jan 22, 2025
d258c04
Bump BSK commit
amddg44 Jan 22, 2025
156649e
Merge remote-tracking branch 'origin/main' into anya/autofill-extensi…
amddg44 Jan 23, 2025
72c1ff7
Bump BSK commit
amddg44 Jan 23, 2025
db27997
Merge remote-tracking branch 'origin/main' into anya/autofill-extensi…
amddg44 Jan 24, 2025
6a20de6
Bump BSK commit
amddg44 Jan 24, 2025
efd4654
Merge remote-tracking branch 'origin/main' into anya/autofill-extensi…
amddg44 Jan 28, 2025
95f275e
Bump BSK commit
amddg44 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DuckDuckGo-macOS.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15374,8 +15374,8 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
requirement = {
branch = 232.0.0;
kind = branch;
kind = revision;
revision = d7f329f9afd15dd97b846db6a4b262fe0cfeb1cd;
};
};
9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
3 changes: 1 addition & 2 deletions DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/BrowserServicesKit",
"state" : {
"branch" : "232.0.0",
"revision" : "204a7de1bc67acd8c8b87a8f55b6f434f11b72f7"
"revision" : "d7f329f9afd15dd97b846db6a4b262fe0cfeb1cd"
}
},
{
Expand Down
3 changes: 2 additions & 1 deletion DuckDuckGo/Application/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,8 @@ final class AppDelegate: NSObject, NSApplicationDelegate {

private func setUpAutofillPixelReporter() {
autofillPixelReporter = AutofillPixelReporter(
userDefaults: .standard,
standardUserDefaults: .standard,
appGroupUserDefaults: nil,
autofillEnabled: AutofillPreferences().askToSaveUsernamesAndPasswords,
eventMapping: EventMapping<AutofillPixelEvent> {event, _, params, _ in
switch event {
Expand Down
3 changes: 2 additions & 1 deletion DuckDuckGo/Menus/MainMenuActions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,8 @@ extension MainViewController {
}
UserDefaults.standard.set(false, forKey: UserDefaultsWrapper<Bool>.Key.homePageContinueSetUpImport.rawValue)

let autofillPixelReporter = AutofillPixelReporter(userDefaults: .standard,
let autofillPixelReporter = AutofillPixelReporter(standardUserDefaults: .standard,
appGroupUserDefaults: nil,
autofillEnabled: AutofillPreferences().askToSaveUsernamesAndPasswords,
eventMapping: EventMapping<AutofillPixelEvent> { _, _, _, _ in },
installDate: nil)
Expand Down