Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy review: Site may be malicious #266

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

mgurgel
Copy link
Collaborator

@mgurgel mgurgel commented Dec 9, 2024

Asana: https://app.asana.com/0/1206594217596623/1208958530747145/f
https://app.asana.com/0/38424471409662/1208863401278206/f

Reviewer: @shakyShane

Description:

  • Copy change on malicious site warning: “Site May Be Deceptive” => “Site May Be Malicious”

Before / After
image

Steps to test this PR:

  1. Visit the preview or run debugger locally with npm run build && npm run preview
  2. Open the phishing or malware screen
  3. Confirm that first line on tracker breakdown reads “Site May Be Malicious"

@mgurgel mgurgel self-assigned this Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for ddgdash ready!

Name Link
🔨 Latest commit 100c3b8
🔍 Latest deploy log https://app.netlify.com/sites/ddgdash/deploys/6761a2e53405980008724465
😎 Deploy Preview https://deploy-preview-266--ddgdash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

NPM

npm i github:duckduckgo/privacy-dashboard#bfd389350700fd3e004458e3ea2030cc4bcc4ce4

Git submodule:

git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227

Swift

.package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "bfd389350700fd3e004458e3ea2030cc4bcc4ce4"),

@mgurgel mgurgel changed the title Site may be malicious - copy change Copy review: Site may be malicious Dec 9, 2024
@mgurgel mgurgel force-pushed the mgurgel/malware-copy-review branch from 917f51b to 100c3b8 Compare December 17, 2024 16:12
@mgurgel mgurgel requested a review from shakyShane December 17, 2024 16:39
@mgurgel mgurgel merged commit 488b414 into main Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants