[WIP] suggestions json tests #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ever get into this state (webview2 will not provide invalid uris to the navigation handlers, it'll fail upstream)
1 task
…suggestions, and fixed up the scores to match the Windows implementation. These all pass on Windows now, but unsure how pinned tabs are handled on macOS since Windows doesn't have those yet.
…indows_canonicalization_tests' into alex/suggestions-tests
mikamikem
reviewed
Mar 5, 2025
| @@ -50,10 +50,10 @@ | |||
| "topHits": [], | |||
| "searchSuggestions": [], | |||
| "localSuggestions": [ | |||
| { "type": "openTab", "title": "New Tab", "subtitle": "DuckDuckGo", "score": 153600, "uri": "duck://newtab", "tabId": "f4386ef1-675d-43f0-b0d3-868488ab9c56" }, | |||
There was a problem hiding this comment.
On the Windows side, we still have this entry as the top local suggestion with the 153600 score. It looks like it's being scored correctly and should be the top local suggestion result. Do you know why it isn't ending up here on macOS?
There was a problem hiding this comment.
It's not shown in open tab suggestions because it's a local New Tab page (duck://newtab) and we only show Settings and Bookmarks local page open tab suggestions
…returned as a tab search suggestion.
|
Added e9127d3 because it was suggesting the tab that was making the request. |
…ess of the suggestion type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task URL: https://app.asana.com/0/1202406491309510/1209499219087611