Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] suggestions json tests #142

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[WIP] suggestions json tests #142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ab7319a
Added exemptions for hosts that can't be parsed into URIs, as we'll n…
RendijsSmukulis Feb 21, 2025
82dcff7
test suggestions json cases
mallexxx Feb 26, 2025
6dce58a
.gitignore
mallexxx Feb 27, 2025
8f29776
updated test cases, add schema, readme, update linter
mallexxx Feb 27, 2025
768e898
Merge remote-tracking branch 'origin/main' into alex/suggestions-tests
mallexxx Feb 28, 2025
40efec4
upd schema
mallexxx Feb 28, 2025
a603811
fix schema linting; update suggestion tests subtitles&scores
mallexxx Feb 28, 2025
91772b0
Added additional tests, made the subtitle optional for "phrase" type …
mikamikem Feb 28, 2025
8b92c14
Fixing up existing test data to conform to the schema and not contain…
mikamikem Mar 3, 2025
c9af3ca
Fixing up linting issues with the test scenarios.
mikamikem Mar 4, 2025
c2514d7
Merge remote-tracking branch 'origin/randy/exempt_invalid_uris_from_w…
mikamikem Mar 4, 2025
cb8be70
remove tabId from historyEntry
mallexxx Mar 4, 2025
c762a82
afjust tests
mallexxx Mar 5, 2025
9e87d3f
fix linter issues
mallexxx Mar 5, 2025
30e9453
Merge remote-tracking branch 'origin/main' into alex/suggestions-tests
mallexxx Mar 5, 2025
f52e7bb
Merge remote-tracking branch 'origin/main' into alex/suggestions-tests
mallexxx Mar 6, 2025
e9127d3
The search is being initiated from "Selected Tab" so it shouldn't be …
mikamikem Mar 6, 2025
781d638
The subtitle for search results should be "Search DuckDuckGo" regardl…
mikamikem Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions suggestions/bookmarks-history-open-tabs-basic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@
"subtitle": "apple.com/mac",
"uri": "https://www.apple.com/mac/",
"score": 307211,
"tabId": "6d5af67d-a2f4-4acb-9f39-6bd7baa378eb"
},
{
"type": "openTab",
Expand Down Expand Up @@ -313,4 +312,4 @@
}
]
}
}
}
3 changes: 1 addition & 2 deletions suggestions/favorite-duped-open-tab.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@
"subtitle": "apple.com/mac",
"uri": "https://www.apple.com/mac/",
"score": 204811,
"tabId": "6d5af67d-a2f4-4acb-9f39-6bd7baa378eb"
},
{
"type": "openTab",
Expand Down Expand Up @@ -313,4 +312,4 @@
}
]
}
}
}
14 changes: 7 additions & 7 deletions suggestions/suggestions-regular-window-tabs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@
{ "tabId": "fbd713a1-a7a5-4843-8b50-3775f2ce1299", "title": "Selected Tab", "uri": "https://another-example.com" },
{ "tabId": "f4386ef1-675d-43f0-b0d3-868488ab9c56", "title": "New Tab", "uri": "duck://newtab" },
{ "tabId": "8f64b4b9-2aac-4d34-bbf6-4641de875d14", "title": "Bookmarks", "uri": "duck://bookmarks" },
{ "tabId": "6c4c6dfd-f8a7-421d-9b8c-a5d3ec94bea4", "title": "Settings", "uri": "duck://settings" },
{ "tabId": "a0b0354b-223f-4a0b-81a7-3d7d4e5b72ff", "title": "Last Tab", "uri": "https://last.com" }
{ "tabId": "6c4c6dfd-f8a7-421d-9b8c-a5d3ec94bea4", "title": "Settings", "uri": "duck://settings" }
]
},
{
"type": "fullyFeatured",
"tabs": [
{ "tabId": "9e5218ca-a187-4481-a193-4284c5657ea1", "title": "Yet Another Example", "uri": "https://yet-another-example.com" },
{ "tabId": "ccd16104-1655-41da-a250-04d41daa0d4f", "title": "Yet Another Example", "uri": "https://yet-another-example.com" },
{ "tabId": "1daf539e-7b40-4757-a8f3-06d48016058c", "title": "Duplicate to Selected Tab", "uri": "https://another-example.com" }
{ "tabId": "1daf539e-7b40-4757-a8f3-06d48016058c", "title": "Duplicate to Selected Tab", "uri": "https://another-example.com" },
{ "tabId": "a0b0354b-223f-4a0b-81a7-3d7d4e5b72ff", "title": "Last Tab", "uri": "https://last.com" }
]
},
{
Expand All @@ -50,10 +50,10 @@
"topHits": [],
"searchSuggestions": [],
"localSuggestions": [
{ "type": "openTab", "title": "New Tab", "subtitle": "DuckDuckGo", "score": 153600, "uri": "duck://newtab", "tabId": "f4386ef1-675d-43f0-b0d3-868488ab9c56" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Windows side, we still have this entry as the top local suggestion with the 153600 score. It looks like it's being scored correctly and should be the top local suggestion result. Do you know why it isn't ending up here on macOS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not shown in open tab suggestions because it's a local New Tab page (duck://newtab) and we only show Settings and Bookmarks local page open tab suggestions

{ "type": "openTab", "title": "Last Tab", "subtitle": "last.com", "score": 102400, "uri": "https://last.com", "tabId": "a0b0354b-223f-4a0b-81a7-3d7d4e5b72ff" },
{ "type": "openTab", "title": "Duplicate to Selected Tab", "subtitle": "another-example.com", "score": 102400, "uri": "https://another-example.com", "tabId": "1daf539e-7b40-4757-a8f3-06d48016058c" },
{ "type": "openTab", "title": "Pinned tab 1", "subtitle": "pinned-example.com", "score": 102400, "uri": "https://pinned-example.com", "tabId": "438165a0-b444-4165-8b28-5b01ada66b05" }
{ "type": "openTab", "title": "Pinned tab 1", "subtitle": "pinned-example.com", "score": 102400, "uri": "https://pinned-example.com" },
{ "type": "openTab", "title": "Pinned tab 2", "subtitle": "pinned-example-2.com", "score": 102400, "uri": "https://pinned-example-2.com" },
{ "type": "openTab", "title": "Selected Tab", "subtitle": "another-example.com", "score": 102400, "uri": "https://another-example.com", "tabId": "FBD713A1-A7A5-4843-8B50-3775F2CE1299" },
{ "type": "openTab", "title": "Last Tab", "subtitle": "last.com", "score": 102400, "uri": "https://last.com", "tabId": "a0b0354b-223f-4a0b-81a7-3d7d4e5b72ff" }
]
}
}
Loading