Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS survey August 2024 #95

Merged
merged 2 commits into from
Aug 12, 2024
Merged

iOS survey August 2024 #95

merged 2 commits into from
Aug 12, 2024

Conversation

samsymons
Copy link
Contributor

Task: https://app.asana.com/0/1193060753475688/1208031021631165/f

This PR adds the August 2024 iOS survey. This PR is the same as previous surveys such as #77.

Testing instructions:

  1. Update RemoteMessageRequest to include the sample URL attached in the comments below
  2. Update shouldProcessConfig to always return true
  3. Now we need to test that the install date range is working. We have no method in the Debug menu for overriding this so for now you'll need to use a local copy of BSK and search for the line case let matchingAttribute as DaysSinceInstalledMatchingAttribute
  4. Underneath the line mentioned above, you can override daysSinceInstall value to check the range. Try it with 0, 5, and 10, and check that the message only appears for the 5 case
  5. Finally, set the value back to one that matches the range, and check that opening the link correctly opens the survey

@samsymons samsymons requested a review from amddg44 August 12, 2024 04:50
@samsymons samsymons requested a review from a team as a code owner August 12, 2024 04:50
@github-actions GitHub Actions
Copy link

Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json

amddg44
amddg44 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one small tweak to add in a missing comma in the rules, but otherwise LGTM!

@amddg44 amddg44 merged commit 0906fa3 into main Aug 12, 2024
1 check passed
samsymons added a commit that referenced this pull request Aug 13, 2024
@samsymons
Merge branch 'main' into sam/macos-privacy-pro-surveys
cd1c4fc 
* main:
  iOS survey August 2024 (#95)
  Enable ppro promo d1-2 (#93)
  Remove the iOS 14 deprecation message (#94)
  New Privacy pro promo for installs between 1 and 2 days (#92)
  iOS Privacy Pro survey update (#91)
@samsymons samsymons mentioned this pull request Oct 10, 2024
Merged
samsymons added a commit that referenced this pull request Oct 11, 2024
@samsymons
Add permanent iOS survey (#108)
0fac882 
Task: https://app.asana.com/0/1207619243206445/1208454188907378/f

This PR adds the permanent iOS survey. This PR is very similar to previous surveys such as #95, except this survey adds a targetPercentile of 0.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amddg44 amddg44 amddg44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @amddg44