Limit transcripts assistant picker to custom assistants only #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albandum
changed the title
spolu
reviewed
May 22, 2024
| const agents = agentConfigurations.filter((a) => a.status === "active"); | ||
| // Only custom assistants - there's no point in passing a transcript to a default assistant without instructions. | ||
| const agents = agentConfigurations.filter( | ||
| (a) => a.status === "active" && a.id != -1 |
There was a problem hiding this comment.
Don't we have a function to filter them out?
There was a problem hiding this comment.
You likely can tweak that instead: agentsGetView: "list",
There was a problem hiding this comment.
Are we actually using agentsGetView?
From the SWR useAgentConfigurations it looks like it, but looking at front/pages/api/v1/w/[wId]/assistant/agent_configurations.ts the GET request does not take into account any query param :/
const agentConfigurations = await getAgentConfigurations({
auth,
agentsGetView: "all",
variant: "light",
});
There was a problem hiding this comment.
oh it should cc @philipperolet who introduced it I believe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now people could add @gpt4 and all default assistants as transcripts processors, which makes no sense.
Removing the possibility to use a default assistant in Transcripts
Risk
Deploy Plan