Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit transcripts assistant picker to custom assistants only #5217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Limit transcripts assistant picker to custom assistants only #5217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion front/pages/w/[wId]/assistant/labs/transcripts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ export default function LabsTranscriptsIndex({
return <Spinner />;
}

const agents = agentConfigurations.filter((a) => a.status === "active");
// Only custom assistants - there's no point in passing a transcript to a default assistant without instructions.
const agents = agentConfigurations.filter(
(a) => a.status === "active" && a.id != -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a function to filter them out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You likely can tweak that instead: agentsGetView: "list",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we actually using agentsGetView?

From the SWR useAgentConfigurations it looks like it, but looking at front/pages/api/v1/w/[wId]/assistant/agent_configurations.ts the GET request does not take into account any query param :/

const agentConfigurations = await getAgentConfigurations({
        auth,
        agentsGetView: "all",
        variant: "light",
      });

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it should cc @philipperolet who introduced it I believe?

);

const handleProviderChange = async (
provider: LabsTranscriptsProviderType
Expand Down
Loading