add option to truncate timeseries #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28 we updated the bandpass filter to make it less susceptible to edge artifacts. Although no new issues have been observed, the performance of any filter will depend on the situation (the properties of both the timeseries and the filter) and it is difficult to assess this in general. To avoid potential issues in the future, we can additionally truncate the timeseries.
This PR piggybacks onto the current scrubbing implementation to additionally remove frames at the beginning and end of the timeseries.
The proposed default of
5is based on the length I've mostly seen for filters (we would like to remove as little as safely possible).