Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple reconstruction steps via commandline #37

Closed
wants to merge 1 commit into from

Conversation

koenhelwegen
Copy link
Member

Due to a small typo the case of multiple reconstruction steps was not handled correctly

@SiemondeLange
Copy link
Member

SiemondeLange commented Nov 21, 2023

Hi,
The reconstruction steps are special input parameters and CATO expects them to be provided as:
structural_pipeline [STEPS]... -s SUBJECTDIR -m MCRROOT [OPTION]...
For example:
structural_pipeline structural_preprocessing fiber_reconstruction -s $SUBJECTDIR -m $MCRDIR

The fix introduced in this PR will break CATO, because the switch statement transforms its input to lowercase text (lower(varName)) and won't match with the changed case 'reconstructionSteps' that includes capitals.

@koenhelwegen
Copy link
Member Author

ah, I see! Then I'm not sure why --general.reconstructionsteps="parcellation,collect_region_properties" works, but --general.reconstructionSteps="parcellation,collect_region_properties" does not?

@koenhelwegen koenhelwegen deleted the fix-multiple-reconstruction-steps branch November 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants