Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout with Japanese and other languages #256

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix layout with Japanese and other languages #256

merged 3 commits into from
Sep 20, 2024

Conversation

ruixhuang
Copy link
Contributor

@ruixhuang ruixhuang commented Sep 18, 2024 •
edited
Loading

Description / Intuition

Fix filter layout with Japanese


Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang ruixhuang marked this pull request as ready for review September 18, 2024 17:00
@ruixhuang ruixhuang changed the title Fix filter layout with Japanese Fix filter layout with Japanese and other languages Sep 18, 2024
@ruixhuang ruixhuang changed the title Fix filter layout with Japanese and other languages Fix layout with Japanese and other languages Sep 18, 2024
@mike-dydx mike-dydx self-requested a review September 20, 2024 14:19
@mike-dydx mike-dydx merged commit 6ab0e84 into develop Sep 20, 2024
5 checks passed
@mike-dydx mike-dydx deleted the features/fix_filter branch September 20, 2024 14:19
mike-dydx pushed a commit that referenced this pull request Oct 16, 2024
@ruixhuang @mike-dydx
Fix layout with Japanese and other languages (#256)
16c6c14 
* Fix filter layout with Japanese

* More fixes

* One more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-dydx mike-dydx mike-dydx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @mike-dydx