Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed parsing rollappID parameter #379

Merged

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner June 28, 2023 09:23
@mtsitrin mtsitrin linked an issue Jun 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #379 (b6b2032) into main (e22c252) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   52.10%   52.08%   -0.03%     
==========================================
  Files          90       90              
  Lines       14255    14259       +4     
==========================================
- Hits         7428     7427       -1     
- Misses       5784     5788       +4     
- Partials     1043     1044       +1     
Impacted Files Coverage Δ
settlement/dymension/dymension.go 59.67% <0.00%> (ø)
config/config.go 39.42% <25.00%> (-0.58%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtsitrin mtsitrin merged commit a6e92dc into main Jun 29, 2023
3 of 5 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/378-read-rollappid-from-flags-as-well-as-toml branch June 29, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read rollappID from flags as well as toml
2 participants