Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated go-cnc to match celetia light node v0.11 #400

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix: updated go-cnc to match celetia light node v0.11 #400

merged 3 commits into from
Jul 20, 2023

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Jul 13, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner July 13, 2023 13:37
@omritoptix omritoptix linked an issue Jul 13, 2023 that may be closed by this pull request
height in the DA path when using celestia is always 0 #396
Closed
@omritoptix omritoptix mentioned this pull request Jul 13, 2023
Closed
@omritoptix
Copy link
Contributor Author

shouldn't be merged until #401 is ready otherwise user will run out of tia fast.

@omritoptix omritoptix merged commit a67e445 into main Jul 20, 2023
3 checks passed
@omritoptix omritoptix deleted the omritoptix/396-da-zero-height-fix branch July 20, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzhakBokris ItzhakBokris ItzhakBokris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

height in the DA path when using celestia is always 0
2 participants
@omritoptix @ItzhakBokris