fix(bug): sync from da and p2p when starting a node #763

srene · 2024-05-01T23:22:57Z

PR Standards

Opening a pull request should be able to meet the following requirements

Close #771 , #761

<-- Briefly describe the content of this pull request -->

For Author:

Targeted PR against correct branch
included the correct type prefix in the PR title
Linked to Github issue with discussion and accepted design
Targets only one github issue
Wrote unit and integration tests
All CI checks have passed
Added relevant godoc comments

For Reviewer:

confirmed the correct type prefix in the PR title
Reviewers assigned
confirmed all author checklist items have been addressed

After reviewer approval:

In case targets main branch, PR should be squashed and merged.
In case PR targets a release branch, PR should be rebased.

block/manager.go

danwt

We need to delete the state index field

dymint/types/state.go

Line 41 in df192a9

SLStateIndex uint64

block/retriever.go

block/manager.go

Co-authored-by: github-actions <[email protected]>

The merge-base changed after approval.

Co-authored-by: danwt <[email protected]> Co-authored-by: github-actions <[email protected]>

srene requested a review from a team as a code owner May 1, 2024 23:22

danwt previously approved these changes May 2, 2024

View reviewed changes

danwt self-requested a review May 2, 2024 11:50

srene dismissed danwt’s stale review via 86321c0 May 2, 2024 12:26

srene force-pushed the srene/fix-syncingfromp2pANDda branch from aca75cf to 86321c0 Compare May 2, 2024 12:26

danwt and others added 11 commits May 2, 2024 14:30

finish impl but without fixing tests, and sync call is in wrong place

7b70862

move the call

8b0a032

add a sanity check log

de0ea98

do not sync celestia on boot

67d30ac

remove process nexct batch

1487d79

keep retrying

3db98d0

comment out celestia

66092f9

revert all temp changes

8725393

fixing da syncing

bac7765

readd availability check

656b017

changing default parameters + logging

a8fdcd1

srene force-pushed the srene/fix-syncingfromp2pANDda branch from 86321c0 to a8fdcd1 Compare May 2, 2024 12:34

setting channel size to gossip cache value

5208955

srene force-pushed the srene/fix-syncingfromp2pANDda branch from fb53623 to 5208955 Compare May 2, 2024 12:45

srene and others added 2 commits May 2, 2024 14:45

Merge 5208955 into 43e2d96

e03ae2c

Update CHANGELOG.md [skip ci]

f5b7981

danwt mentioned this pull request May 2, 2024

fix(sync) initial block height when getting state #764

Closed

12 tasks

srene added 2 commits May 2, 2024 15:19

using unbuffered subscriptions

f6adc27

removing unused func

4c4442d

github-advanced-security bot found potential problems May 2, 2024

View reviewed changes

block/manager.go Fixed Show fixed Hide fixed

danwt requested changes May 2, 2024

View reviewed changes

block/retriever.go Outdated Show resolved Hide resolved

danwt reviewed May 2, 2024

View reviewed changes

block/retriever.go Outdated Show resolved Hide resolved

danwt added 3 commits May 2, 2024 14:49

refac/simplify sync until target

78780ed

make sync until target more readable

132fc6e

add comment for retriever

02a41ba

srene dismissed danwt’s stale review via a25d74b May 2, 2024 14:16

srene and others added 2 commits May 2, 2024 14:16

Merge a25d74b into 53002b0

09e7199

Update CHANGELOG.md [skip ci]

4cc17dd

danwt mentioned this pull request May 2, 2024

bug: GetHeightState for height = 0 #761

Closed

danwt requested changes May 2, 2024

View reviewed changes

block/manager.go Outdated Show resolved Hide resolved

srene and others added 2 commits May 2, 2024 16:25

fix logging

c7f6e7a

fix(doc): manager cache comment (#767)

b88bf6e

Co-authored-by: github-actions <[email protected]>

danwt self-requested a review May 2, 2024 14:34

danwt previously approved these changes May 2, 2024

View reviewed changes

danwt self-requested a review May 2, 2024 14:42

danwt previously approved these changes May 2, 2024

View reviewed changes

danwt self-requested a review May 2, 2024 15:15

danwt previously approved these changes May 2, 2024

View reviewed changes

danwt and others added 3 commits May 2, 2024 16:25

add state index back to proto

5cee763

Merge 5cee763 into b88bf6e

d101799

Update CHANGELOG.md [skip ci]

91bb364

danwt mentioned this pull request May 2, 2024

fix(settlement): remove state index from proto #777

Merged

omritoptix previously approved these changes May 2, 2024

View reviewed changes

danwt requested review from danwt and omritoptix May 2, 2024 15:53

danwt previously approved these changes May 2, 2024

View reviewed changes

omritoptix merged commit 68ffd05 into main May 2, 2024

omritoptix deleted the srene/fix-syncingfromp2pANDda branch May 2, 2024 15:55

omritoptix pushed a commit that referenced this pull request May 2, 2024

fix(bug): sync from da and p2p when starting a node (#763)

bafb117

Co-authored-by: danwt <[email protected]> Co-authored-by: github-actions <[email protected]>

srene linked an issue May 6, 2024 that may be closed by this pull request

bug: p2p gossiped blocks are not cached when starting #762

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(bug): sync from da and p2p when starting a node #763

fix(bug): sync from da and p2p when starting a node #763

srene commented May 1, 2024 •

edited by danwt

Loading

danwt left a comment

fix(bug): sync from da and p2p when starting a node #763

fix(bug): sync from da and p2p when starting a node #763

Conversation

srene commented May 1, 2024 • edited by danwt Loading

PR Standards

Opening a pull request should be able to meet the following requirements

danwt left a comment

Choose a reason for hiding this comment

srene commented May 1, 2024 •

edited by danwt

Loading