Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bilingual RewardPointRedemptionEvent names #2380

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bilingual RewardPointRedemptionEvent names #2380

wants to merge 4 commits into from

Conversation

jooooosef
Copy link
Collaborator

fix #2175

Kakadus
Kakadus requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unnecessary comment

evap/rewards/models.py Outdated Show resolved Hide resolved
@jooooosef
Copy link
Collaborator Author

jooooosef commented Jan 28, 2025 •
edited
Loading

@Kakadus I think I also need to apply the new field and reanem to the test_data right? Because otherwise doing python manage.py loaddata test_data will not work, since this relies on the old filed name and does not use name_de and name_en right?

At least thats why I think the test here fails...

@niklasmohrin
Copy link
Member

niklasmohrin commented Jan 28, 2025 •
edited
Loading

Correct! You can use manage.py dump_testdata for that :)

@jooooosef jooooosef force-pushed the iss2175 branch 2 times, most recently from 92f0940 to 4b0a774 Compare February 3, 2025 19:03
janno42
janno42 requested changes Feb 3, 2025
View reviewed changes
evap/development/fixtures/test_data.json Show resolved Hide resolved
evap/development/fixtures/test_data.json Show resolved Hide resolved
evap/rewards/migrations/0007_localize_rewardpointredemption_name.py Outdated Show resolved Hide resolved
evap/rewards/tests/test_views.py Outdated Show resolved Hide resolved
evap/rewards/tests/test_views.py Outdated Show resolved Hide resolved
evap/rewards/tests/test_views.py Outdated Show resolved Hide resolved
@jooooosef
add migrations for rewards
e006124 
wanted to add name_de and name_en so there needs to be the approiate migration
@jooooosef
implemented name_de and name_en of rewardredemptionevent
3e6ec71 
in the model and the form
@jooooosef
fix tests for redemption reward
119fcb8
@jooooosef
update test_data
0dfbd5c 
the test_data.json needs to reflect the name_de and name_en changes
janno42
janno42 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬

@jooooosef jooooosef requested a review from Kakadus February 10, 2025 17:21
richardebeling
richardebeling approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janno42 janno42 janno42 approved these changes

@richardebeling richardebeling richardebeling approved these changes

@Kakadus Kakadus Awaiting requested review from Kakadus

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bilingual RewardPointRedemptionEvent names
5 participants
@jooooosef @niklasmohrin @janno42 @richardebeling @Kakadus