-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21351] Refactor TopicDataType
#375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
changed the title
Remove old TopicDataType functions
[21351] Remove old TopicDataType functions
Jul 12, 2024
8 tasks
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
This was referenced Jul 16, 2024
MiguelCompany
previously approved these changes
Jul 17, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
MiguelCompany
previously approved these changes
Jul 17, 2024
6 tasks
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 18, 2024 05:51
MiguelCompany
approved these changes
Jul 18, 2024
MiguelCompany
changed the title
[21351] Remove old TopicDataType functions
[21351] Refactor Jul 18, 2024
TopicDataType
MiguelCompany
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of XCDR introduces new functions in
TopicDataType
class. But the old one remained. This PR removes them before launching the major version 3, and also performs additional refactorings:snake_case
and have more meaningful names.std::string
instead ofchar*
on name getters and settersContributor Checklist
Reviewer Checklist