[20933] Set DataSharing in Writer|ReaderProxyData #4761

elianalf · 2024-05-08T15:03:15Z

Description

Previously, Writer|ReaderProxyData always reported DataSharing as AUTO. This PR set it to ON or OFF based on the PID_DATASHARING.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: elianalf <[email protected]>

The base branch was changed.

Signed-off-by: elianalf <[email protected]>

elianalf · 2024-05-16T05:39:23Z

@richiprosima please test_3 this

elianalf · 2024-05-17T07:52:21Z

@richiprosima please test_3 linux

JesusPoderoso

LGTM, good job!

test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp

EduPonz · 2024-05-17T11:22:10Z

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

mergify · 2024-05-17T11:22:16Z

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4801 [20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) has been created for branch 2.14.x but encountered conflicts
#4802 [20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) has been created for branch 2.13.x but encountered conflicts
#4803 [20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) has been created for branch 2.10.x but encountered conflicts
#4804 [20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) has been created for branch 2.6.x but encountered conflicts

Signed-off-by: elianalf <[email protected]>

* Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523) # Conflicts: # test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp

* Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523)

* Set DataSharing in Writer|ReaderProxyData (#4761) * Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523) # Conflicts: # test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp * Refs #20933: Fix conflicts Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> Co-authored-by: elianalf <[email protected]> Co-authored-by: eduponz <[email protected]>

* Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523)

* Set DataSharing in Writer|ReaderProxyData (#4761) * Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523) * Fix build after solving conflicts. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: elianalf <[email protected]> Co-authored-by: Miguel Company <[email protected]>

* Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523) Co-authored-by: elianalf <[email protected]>

* Set DataSharing in Writer|ReaderProxyData (#4761) * Refs #20933: Set datasharing on when pid is found Signed-off-by: elianalf <[email protected]> * Refs #20933: Set datasharing off after the clear Signed-off-by: elianalf <[email protected]> * Refs #20933: Add tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test Signed-off-by: elianalf <[email protected]> * Refs #20933: Change implementation to fix failing tests Signed-off-by: elianalf <[email protected]> * Refs #20933: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 904c523) * Refs #20933: Applu suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> Co-authored-by: elianalf <[email protected]>

elianalf added this to the v3.0.0 milestone May 8, 2024

elianalf force-pushed the bugfix/proxy_data_data_sharing branch from a8edff3 to 8607cf8 Compare May 8, 2024 15:06

EduPonz force-pushed the 3.0.x-devel branch from 08ee62b to 623db82 Compare May 13, 2024 09:26

elianalf added 3 commits May 13, 2024 15:47

Refs #20933: Set datasharing on when pid is found

956debe

Signed-off-by: elianalf <[email protected]>

Refs #20933: Set datasharing off after the clear

c524bf2

Signed-off-by: elianalf <[email protected]>

Refs #20933: Add tests

5ca4a18

Signed-off-by: elianalf <[email protected]>

elianalf force-pushed the bugfix/proxy_data_data_sharing branch from 57067e2 to 5ca4a18 Compare May 13, 2024 13:47

JesusPoderoso self-requested a review May 13, 2024 13:50

github-actions bot added the ci-pending PR which CI is running label May 13, 2024

This comment was marked as outdated.

Sign in to view

EduPonz deleted the branch master May 14, 2024 07:22

EduPonz closed this May 14, 2024

EduPonz reopened this May 14, 2024

EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:25

elianalf added needs-review PR that is ready to be reviewed and removed needs-review PR that is ready to be reviewed labels May 14, 2024

Refs #20933: Fix other_vendor_parameter_list_with_custom_pids test

f47d5bd

Signed-off-by: elianalf <[email protected]>

elianalf requested a review from JesusPoderoso May 14, 2024 14:51

Refs #20933: Change implementation to fix failing tests

9c36480

Signed-off-by: elianalf <[email protected]>

elianalf force-pushed the bugfix/proxy_data_data_sharing branch from 582f14f to 9c36480 Compare May 14, 2024 14:52

elianalf requested review from JesusPoderoso and removed request for JesusPoderoso May 14, 2024 14:52

JesusPoderoso previously approved these changes May 17, 2024

View reviewed changes

JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 17, 2024

EduPonz suggested changes May 17, 2024

View reviewed changes

EduPonz added the skip-ci Automatically pass CI label May 17, 2024

EduPonz changed the title ~~[20933 ] Set DataSharing in Writer|ReaderProxyData~~ [20933] Set DataSharing in Writer|ReaderProxyData May 17, 2024

Refs #20933: Apply suggestions

f8dd5a9

Signed-off-by: elianalf <[email protected]>

elianalf dismissed JesusPoderoso’s stale review via f8dd5a9 May 17, 2024 11:52

EduPonz approved these changes May 17, 2024

View reviewed changes

EduPonz merged commit 904c523 into master May 17, 2024
3 checks passed

EduPonz deleted the bugfix/proxy_data_data_sharing branch May 17, 2024 11:55

mergify bot mentioned this pull request May 17, 2024

[20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) #4801

Merged

12 tasks

mergify bot mentioned this pull request May 17, 2024

[20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) #4802

Merged

12 tasks

mergify bot mentioned this pull request May 17, 2024

[20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) #4803

Merged

12 tasks

mergify bot mentioned this pull request May 17, 2024

[20933] Set DataSharing in Writer|ReaderProxyData (backport #4761) #4804

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20933] Set DataSharing in Writer|ReaderProxyData #4761

[20933] Set DataSharing in Writer|ReaderProxyData #4761

elianalf commented May 8, 2024 •

edited by JesusPoderoso

Loading

This comment was marked as outdated.

elianalf commented May 16, 2024

elianalf commented May 17, 2024

JesusPoderoso left a comment

EduPonz commented May 17, 2024

mergify bot commented May 17, 2024 •

edited

Loading

[20933] Set DataSharing in Writer|ReaderProxyData #4761

[20933] Set DataSharing in Writer|ReaderProxyData #4761

Conversation

elianalf commented May 8, 2024 • edited by JesusPoderoso Loading

Description

Contributor Checklist

Reviewer Checklist

This comment was marked as outdated.

elianalf commented May 16, 2024

elianalf commented May 17, 2024

JesusPoderoso left a comment

Choose a reason for hiding this comment

EduPonz commented May 17, 2024

mergify bot commented May 17, 2024 • edited Loading

✅ Backports have been created

elianalf commented May 8, 2024 •

edited by JesusPoderoso

Loading

mergify bot commented May 17, 2024 •

edited

Loading