Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21538] Allow all durability configurations #5224

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 11, 2024

Description

This PR:

  • Allows the creation of a DataWriter/Reader with a PERSISTENT durability, but behaving as TRANSIENT.
  • When in TRANSIENT, if no persistence guid is given, it fallbacks to TRANSIENT_LOCAL.
  • Refactors BB make_transient() make_persitent() pubsub API to be clearer about the intention of making a transient or persistent endpoint.
  • Adds BB tests for the purpose.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.2 milestone Sep 11, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 11, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima September 11, 2024 19:42
@Mario-DL Mario-DL added doc-pending Issue or PR which is pending to be documented versions-pending and removed ci-pending PR which CI is running labels Sep 12, 2024
@Mario-DL Mario-DL modified the milestones: v3.0.2, v3.1.0 Sep 12, 2024
@Mario-DL Mario-DL added needs-review PR that is ready to be reviewed and removed doc-pending Issue or PR which is pending to be documented versions-pending labels Sep 12, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments below, I think we can consider that we fully support PERSISTENT durability, since I think it is what we currently support.

From the standard:

Data is kept on permanent storage, so that they can outlive a system session.

This means we could remove the warning on check_qos

test/unittest/dds/participant/ParticipantTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/publisher/DataWriterTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/subscriber/DataReaderTests.cpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany added blocked-till-branch-out and removed needs-review PR that is ready to be reviewed labels Sep 23, 2024
Signed-off-by: Mario Dominguez <[email protected]>
…b test API to make it clearer

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 3, 2024
@MiguelCompany MiguelCompany merged commit ed58ca2 into master Oct 3, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the feature/21538 branch October 3, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants