-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21538] Allow all durability
configurations
#5224
Conversation
0029486
to
456a976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comments below, I think we can consider that we fully support PERSISTENT
durability, since I think it is what we currently support.
From the standard:
Data is kept on permanent storage, so that they can outlive a system session.
This means we could remove the warning on check_qos
fca47eb
to
3be074c
Compare
Signed-off-by: Mario Dominguez <[email protected]>
…b test API to make it clearer Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
3be074c
to
caaea00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Description
This PR:
PERSISTENT
durability, but behaving asTRANSIENT
.TRANSIENT
, if no persistence guid is given, it fallbacks toTRANSIENT_LOCAL
.make_transient()
make_persitent()
pubsub API to be clearer about the intention of making a transient or persistent endpoint.Contributor Checklist
versions.md
file (if applicable).durability
configurations Fast-DDS-docs#907Reviewer Checklist