[22006] Transform locators using new host_id PID - ABI compatible #5381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new PID containing a UUID of the machine/host. It is used to check if the metadata of other participants comes from the same host in a more reliable approach than the GUID comparison, which uses IP addresses interfaces.
This feature solves a bug in which a TCP client connecting to
localhost
is unable to identify the locator of a TCP discovery server with a custom GUID listening onany
. This causes the client to create two different channels for the same connection, where the latest can never be reached. The reason is that the server's locator is not considered from the same host due to its custom GUID. Hence, the server transforms the client's locator intolocalhost
but the client does not do the same with the server's locator.Another PR needs to be created for 3.2.x with the new PID properly added to
ParameterTypes.hpp
. That PR will not be backported.@Mergifyio backport 3.0.x 2.14.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist