Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22006] Transform locators using new host_id PID - ABI compatible #5381

Closed
wants to merge 9 commits into from

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Nov 4, 2024

Description

This PR adds a new PID containing a UUID of the machine/host. It is used to check if the metadata of other participants comes from the same host in a more reliable approach than the GUID comparison, which uses IP addresses interfaces.

This feature solves a bug in which a TCP client connecting to localhost is unable to identify the locator of a TCP discovery server with a custom GUID listening on any. This causes the client to create two different channels for the same connection, where the latest can never be reached. The reason is that the server's locator is not considered from the same host due to its custom GUID. Hence, the server transforms the client's locator into localhost but the client does not do the same with the server's locator.

Another PR needs to be created for 3.2.x with the new PID properly added to ParameterTypes.hpp. That PR will not be backported.

@Mergifyio backport 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally. Related test: [22056] Transform locators using new host_id PID Discovery-Server#106
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz force-pushed the feature/add_host_id_to_dataP_3.1 branch from 8f88229 to 8e28fd2 Compare November 5, 2024 07:03
@cferreiragonz
Copy link
Contributor Author

This PR will be closed and replaced by the backport from PR:

@cferreiragonz cferreiragonz deleted the feature/add_host_id_to_dataP_3.1 branch November 6, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant