-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22056] Transform locators using new machine_id PID #5382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
cferreiragonz
changed the title
[22006] Transform locators using new host_id PID - Not-ABI compatible
[22056] Transform locators using new host_id PID
Nov 5, 2024
cferreiragonz
force-pushed
the
feature/pid_host_id_to_parameterTypes
branch
from
November 5, 2024 08:50
c214300
to
ecfb2fc
Compare
10 tasks
cferreiragonz
force-pushed
the
feature/pid_host_id_to_parameterTypes
branch
from
November 5, 2024 10:30
85482dc
to
f002c9d
Compare
MiguelCompany
changed the title
[22056] Transform locators using new host_id PID
[22056] Transform locators using new machine_id PID
Nov 5, 2024
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
November 6, 2024 11:49
9 tasks
MiguelCompany
requested changes
Nov 11, 2024
cferreiragonz
force-pushed
the
feature/pid_host_id_to_parameterTypes
branch
from
November 12, 2024 07:42
85b7233
to
82d589f
Compare
MiguelCompany
requested changes
Nov 12, 2024
MiguelCompany
requested changes
Nov 12, 2024
cferreiragonz
force-pushed
the
feature/pid_host_id_to_parameterTypes
branch
from
November 13, 2024 09:11
6bbd2cd
to
986304a
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
November 13, 2024 09:11
MiguelCompany
requested changes
Nov 13, 2024
MiguelCompany
previously approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
MiguelCompany
requested changes
Nov 14, 2024
cferreiragonz
force-pushed
the
feature/pid_host_id_to_parameterTypes
branch
from
November 14, 2024 10:32
b700f53
to
6b99a05
Compare
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
…nitialized Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
… existing channel Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
cferreiragonz
force-pushed
the
feature/pid_host_id_to_parameterTypes
branch
from
November 15, 2024 08:59
cf16403
to
217e9ae
Compare
MiguelCompany
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
cferreiragonz
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Nov 18, 2024
9 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new PID containing a UUID of the machine/host. It is used to check if the metadata of other participants comes from the same host in a more reliable approach than the GUID comparison, which uses IP addresses interfaces. It also checks if the locator used as key when a new channel is added to the
channel_resources_
map contains a local interface. In this case, a localhost locator is also linked to the same channel, to ensure that the participant can use a single channel for both localhost and the local interface. This does NOT duplicate sent messages, it only reuses the same TCP channel for two different locators, localhost and the specified IP address.This feature solves a bug in which a TCP client connecting to
localhost
is unable to identify the locator of a TCP discovery server with a custom GUID listening onany
. This causes the client to create two different channels for the same connection, where the latest can never be reached. The reason is that the server's locator is not considered from the same host due to its custom GUID. Hence, the server transforms the client's locator intolocalhost
but the client does not do the same with the server's locator.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist