[19450] Fix Linux installations from sources docs #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Ponz <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Refs #19450: Add workflows for testing installation methods nightly Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Correctly override ROS 2 packages Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Install missing dependencies Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Ignore some docs packages Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Upgrade checkout action to v4 on docs.yaml Signed-off-by: Eduardo Ponz <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> (cherry picked from commit b23560f) # Conflicts: # docs/resources/scripts/linux_source_installation.bash
rsanchez15
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Refs #19450: Add workflows for testing installation methods nightly Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Correctly override ROS 2 packages Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Install missing dependencies Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Ignore some docs packages Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Upgrade checkout action to v4 on docs.yaml Signed-off-by: Eduardo Ponz <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> (cherry picked from commit b23560f) # Conflicts: # docs/resources/scripts/linux_source_installation.bash
rsanchez15
added a commit
that referenced
this pull request
Feb 6, 2024
* Fix Linux installations from sources docs (#151) * Refs #19450: Add workflows for testing installation methods nightly Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Correctly override ROS 2 packages Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Install missing dependencies Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Ignore some docs packages Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19450: Upgrade checkout action to v4 on docs.yaml Signed-off-by: Eduardo Ponz <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> (cherry picked from commit b23560f) # Conflicts: # docs/resources/scripts/linux_source_installation.bash * Resolve conflicts Signed-off-by: Raul Sanchez-Mateos <[email protected]> --------- Signed-off-by: Raul Sanchez-Mateos <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: Raul Sanchez-Mateos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux installation from sources documentation was missing some dependencies, was not correctly overriding some ROS 2 packages, and was trying to compile unnecessary docs projects. This PR fixes those issues and also adds 2 workflows to check the installation methods (sources and binaries) nightly to avoid problems in the future.
To test the PR locally run
bash docs/resources/scripts/linux_source_installation.bash. I recommend doing so within a Ubuntu 22.04 docker container to avoid installation of apt packages on the host machine.