Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rewriting pages about editors #2552

Merged
merged 50 commits into from
Mar 14, 2023
Merged

docs: Rewriting pages about editors #2552

merged 50 commits into from
Mar 14, 2023

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Feb 13, 2023

What does this pull request change?

This PR improves the docs pages about editors.

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-4789

Specify the version of the product this pull request applies to

Merge to main.
Cherry-pick to 7.60.x, 7.61.x, 7.62.x.

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@max-cx max-cx requested review from rkratky and a team as code owners February 13, 2023 17:44
@github-actions
Copy link

github-actions bot commented Feb 13, 2023

🎊 Navigate the preview: https://641aaf1f951bef5e4337877c--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@@ -0,0 +1,58 @@

[id="adding-vs-code-extensions"]
= Adding `VS Code` extensions
Copy link
Contributor

@l0rd l0rd Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= Adding `VS Code` extensions
= Automating VS Code extensions installation at worksapce startup

Adding an extension is about manually installing a VS Code extensions via the extensions view. But this section is about something else: it's about configuring your repository so that the extensions get installed automatically.

If we leave it like that, a user may think that the only way to add an extensions is adding a .vscode/extensions.json in the git repository (something he may not do if he is not a maintainer of the repo).

Copy link
Contributor Author

@max-cx max-cx Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you. I'm applying this suggestion, just with a slight rewording:
= Automating installation of Microsoft Visual Studio Code extensions at workspace startup
(Unfortunately, the IDE name has to be longer.)

@max-cx max-cx merged commit 7e669af into eclipse-che:main Mar 14, 2023
max-cx added a commit that referenced this pull request Mar 14, 2023
* initial changes

* fix: rewriting the IDE-related pages

* edit 'Adding or removing extensions in the embedded Open VSX registry instance'

* rewrite the assembly and remove the outdated concept module

* new edits

* further edits

* fix: typo

* remove the mention of the editorconfig file

* Update modules/end-user-guide/pages/url-parameter-for-the-cloud-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* Update modules/end-user-guide/pages/url-parameter-for-the-cloud-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* initial changes in response to Mario's feedback

* work in progress

* remove 'cloud' from IDE

* add an admonition requested by Mario

* incorporate new feedback from Artem

* Restarting the jobs

* Add 'Restart Workspace from Local Devfile' command to the corresponding section

Co-authored-by: Max Leonov <[email protected]>

* rewrite of the vsx-related procedure due to changes in vsx.org

* Update modules/end-user-guide/partials/proc_adding-vs-code-extensions.adoc

* edit proc_adding-or-removing-extensions-in-the-embedded-open-vsx-registry-instance.adoc

* Apply suggestions from code review

* Update modules/end-user-guide/pages/defining-a-common-ide.adoc

* Update modules/end-user-guide/pages/url-parameter-for-the-ide.adoc

* Update modules/end-user-guide/pages/ides-in-workspaces.adoc

Co-authored-by: Jana Vrbkova <[email protected]>

* Apply suggestions from code review

* minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* minor edit

* minor edit

* minor edit

* apply changes requested in #2552 (comment)

* manually apply suggestion from code review

* minor edit

* test rearranging the steps due to the snippet file

* rearrange admonition content

* minor edit

* minor edit

* Update modules/end-user-guide/pages/microsoft-visual-studio-code-open-source-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* Update modules/end-user-guide/partials/proc_adding-vs-code-extensions.adoc

* rename section heading and file name

* edit the section heading and file name

* minor edit

* merge two tips

* temporary xref fix - correct text, parking file

* temporary cross-reference fix

---------

Co-authored-by: Mario Loriedo <[email protected]>
Co-authored-by: RomanNikitenko <[email protected]>
Co-authored-by: Jana Vrbkova <[email protected]>
max-cx added a commit that referenced this pull request Mar 14, 2023
* initial changes

* fix: rewriting the IDE-related pages

* edit 'Adding or removing extensions in the embedded Open VSX registry instance'

* rewrite the assembly and remove the outdated concept module

* new edits

* further edits

* fix: typo

* remove the mention of the editorconfig file

* Update modules/end-user-guide/pages/url-parameter-for-the-cloud-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* Update modules/end-user-guide/pages/url-parameter-for-the-cloud-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* initial changes in response to Mario's feedback

* work in progress

* remove 'cloud' from IDE

* add an admonition requested by Mario

* incorporate new feedback from Artem

* Restarting the jobs

* Add 'Restart Workspace from Local Devfile' command to the corresponding section

Co-authored-by: Max Leonov <[email protected]>

* rewrite of the vsx-related procedure due to changes in vsx.org

* Update modules/end-user-guide/partials/proc_adding-vs-code-extensions.adoc

* edit proc_adding-or-removing-extensions-in-the-embedded-open-vsx-registry-instance.adoc

* Apply suggestions from code review

* Update modules/end-user-guide/pages/defining-a-common-ide.adoc

* Update modules/end-user-guide/pages/url-parameter-for-the-ide.adoc

* Update modules/end-user-guide/pages/ides-in-workspaces.adoc

Co-authored-by: Jana Vrbkova <[email protected]>

* Apply suggestions from code review

* minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* minor edit

* minor edit

* minor edit

* apply changes requested in #2552 (comment)

* manually apply suggestion from code review

* minor edit

* test rearranging the steps due to the snippet file

* rearrange admonition content

* minor edit

* minor edit

* Update modules/end-user-guide/pages/microsoft-visual-studio-code-open-source-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* Update modules/end-user-guide/partials/proc_adding-vs-code-extensions.adoc

* rename section heading and file name

* edit the section heading and file name

* minor edit

* merge two tips

* temporary xref fix - correct text, parking file

* temporary cross-reference fix

---------

Co-authored-by: Mario Loriedo <[email protected]>
Co-authored-by: RomanNikitenko <[email protected]>
Co-authored-by: Jana Vrbkova <[email protected]>
max-cx added a commit that referenced this pull request Mar 14, 2023
* initial changes

* fix: rewriting the IDE-related pages

* edit 'Adding or removing extensions in the embedded Open VSX registry instance'

* rewrite the assembly and remove the outdated concept module

* new edits

* further edits

* fix: typo

* remove the mention of the editorconfig file

* Update modules/end-user-guide/pages/url-parameter-for-the-cloud-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* Update modules/end-user-guide/pages/url-parameter-for-the-cloud-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* initial changes in response to Mario's feedback

* work in progress

* remove 'cloud' from IDE

* add an admonition requested by Mario

* incorporate new feedback from Artem

* Restarting the jobs

* Add 'Restart Workspace from Local Devfile' command to the corresponding section

Co-authored-by: Max Leonov <[email protected]>

* rewrite of the vsx-related procedure due to changes in vsx.org

* Update modules/end-user-guide/partials/proc_adding-vs-code-extensions.adoc

* edit proc_adding-or-removing-extensions-in-the-embedded-open-vsx-registry-instance.adoc

* Apply suggestions from code review

* Update modules/end-user-guide/pages/defining-a-common-ide.adoc

* Update modules/end-user-guide/pages/url-parameter-for-the-ide.adoc

* Update modules/end-user-guide/pages/ides-in-workspaces.adoc

Co-authored-by: Jana Vrbkova <[email protected]>

* Apply suggestions from code review

* minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* another minor edit

* minor edit

* minor edit

* minor edit

* apply changes requested in #2552 (comment)

* manually apply suggestion from code review

* minor edit

* test rearranging the steps due to the snippet file

* rearrange admonition content

* minor edit

* minor edit

* Update modules/end-user-guide/pages/microsoft-visual-studio-code-open-source-ide.adoc

Co-authored-by: Mario Loriedo <[email protected]>

* Update modules/end-user-guide/partials/proc_adding-vs-code-extensions.adoc

* rename section heading and file name

* edit the section heading and file name

* minor edit

* merge two tips

* temporary xref fix - correct text, parking file

* temporary cross-reference fix

---------

Co-authored-by: Mario Loriedo <[email protected]>
Co-authored-by: RomanNikitenko <[email protected]>
Co-authored-by: Jana Vrbkova <[email protected]>
@max-cx max-cx deleted the 4789 branch March 14, 2023 17:28
@che-bot che-bot added this to the 7.63 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants