Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Rewriting pages about editors #2552
docs: Rewriting pages about editors #2552
Changes from 43 commits
e567fbb
93eef14
2462606
39b74e3
f2bcf40
d862bca
8aadf90
a373437
ba4cc1e
d9ad0d2
7accd9e
d0c5266
77b50ae
0b442cf
4d20a87
0aeb0c3
9743d6f
3ef0dd1
98d201c
a98bf3c
5e17d50
b8c0262
80378d4
d24ef3c
50e778c
d4deb4a
8059611
1a55e18
2fd4265
7372f25
3c73c24
1540524
a2416df
4e7297c
70e68be
0bd023f
698bfd4
9733ed6
293b3f4
74b9d2d
bedfd05
4170924
958b6cf
2b54c41
47d4edd
1cdb621
1484bd3
31252fe
3b3bb4f
d5a6c2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not refer to 'next', 'previous', etc. parts of the docs. Provide a link if pertinent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responding to the above and #2552 (comment):
I can't provide a link to a procedure module AFAIK. This is a toolchain limitation AFAIK.
If you know how to do so, please tell me. If not, then I'll welcome an alternative suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I can do here is spell out the other section's heading. So I'm not sure what's worse, spelling out a section heading without a URL or saying that it's the next section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref:#adding-vs-code-extensions[]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd get rid of the self-referential bit: "as explained in the next section"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) I actually don't think that this is self-referential. It's referring to another section. Ideally, I would have named and linked the other section (as we cross-reference other sections elsewhere in the docs), but I don't think it's technically possible here. Moreover, it's just the next section, so this also makes it clear to the reader to just keep reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modules should be self-contained, however. If the page layout changes and we move things around, the next section you're referring to might be in a different place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deerskindoll is right. Referring to previous, next etc. is not a good idea. Do not assume that the docs are read/used in a sequential manner. Either remove the reference, or use a link.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.