This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Move sidecar fs init out of che API init #1202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
requested review from
azatsarynnyy,
benoitf,
RomanNikitenko and
vzhukovs
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 32.78% 32.42% -0.37%
==========================================
Files 290 294 +4
Lines 9885 9967 +82
Branches 1457 1466 +9
==========================================
- Hits 3241 3232 -9
- Misses 6641 6732 +91
Partials 3 3
Continue to review full report at Codecov.
|
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
[crw-ci-test] |
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
[crw-ci-test --rebuild] |
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder [email protected]
What does this PR do?
Moves the initialization of the sidecar files system and resource loader out of the API setup function. These classes only are used when the Che API is running inside a sidecar, so there is no reason to run them in the front end. This allows to remove some stuff from the webpack config, since it's no longer referenced from the Che API proper.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20331
How to test this PR?
Since we have no front-end plugins using Che, we can't really test that case, but we should make sure the Che-related views ("My Workspace") are still working.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable