Eliminate Conan #432
Merged
Eliminate Conan #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the only thing standing in the way of a successful C++11 build. Signed-off-by: Erik Boasson <[email protected]>
ThijsSassen
reviewed
Jul 18, 2023
.azure/templates/build-test.yml
Outdated
| -DANALYZER=${ANALYZER:-off} \ | ||
| -DSANITIZER=${SANITIZER:-none} \ | ||
| -DENABLE_SHM=${ICEORYX:-off} \ | ||
| -DENABLE_COVERAGE=${COVERAGE:-off} \ | ||
| -DENABLE_LEGACY=${LEGACY:-off} \ | ||
| -DBUILD_TESTING=on \ | ||
| -DBUILD_TESTING=${TESTING:-on} \ |
There was a problem hiding this comment.
Why is testing added as an argument as there is not a single build using it?
There was a problem hiding this comment.
Because I added it in while figuring out what to do with Google Test not supporting C++11 (it turned out I needed to use an older release), and then forgot to remove it again. I'll remove it now.
* Download and build Google Test on the fly on Windows, Linux: Windows because it is the only way to get it, Linux because we need a version that still supports C++. (macOS: homebrew does just fine.) * Move C++11 build to Linux: it is the only one that requires boost, and installing boost on Windows via Chocolatey takes forever whereas on Linux "apt install" is done nearly instantaneously. * PIP cacheing is no longer needed. * Bison has not been needed for a long time, so stop installing it. Signed-off-by: Erik Boasson <[email protected]>
eboasson
force-pushed
the
eliminate-conan
branch
from
0cd97e0
to
a14a50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to eclipse-cyclonedds/cyclonedds#1767