Some more backports to 010x #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an Entity with a Listener, any instantaneous events that occurred during creation would miss their callback. This was caused by the C++ API not being able to wrap the underlying C API with a C++ object prior to C already trying to invoking the callback. That is now resolved by not setting the Listener at creation time, but by setting it after successfully putting a C++ wrapper around the underlying C Entity. This should fix issue eclipse-cyclonedds#410 A prerequisite for applying this fix is to make sure pull request #eclipse-cyclonedds/cyclonedds#1717 is applied to the cyclonedds repository. Signed-off-by: Erik Hendriks <[email protected]>
* Added writer batching QoSPolicy To mirror the implementation of the writer batching QoSPolicy in CycloneDDS-C commit d6906eb Signed-off-by: Martijn Reicher <[email protected]> * Added writer batching in throughput example This is handled through the WriterBatching QoSPolicy Signed-off-by: Martijn Reicher <[email protected]> * Modified comments due to GitHub review Signed-off-by: Martijn Reicher <[email protected]> --------- Signed-off-by: Martijn Reicher <[email protected]>
Signed-off-by: Erik Boasson <[email protected]>
* Download and build Google Test on the fly on Windows, Linux: Windows because it is the only way to get it, Linux because we need a version that still supports C++. (macOS: homebrew does just fine.) * Move C++11 build to Linux: it is the only one that requires boost, and installing boost on Windows via Chocolatey takes forever whereas on Linux "apt install" is done nearly instantaneously. * PIP cacheing is no longer needed. * Bison has not been needed for a long time, so stop installing it. Signed-off-by: Erik Boasson <[email protected]>
|
Hi @eboasson, i tested this branch with the other 0.10.4 PR from CycloneDDS C-Part. The only thing i noticed was the removal of the conan setup in CMakelists.txt. I also was able to compile it successfully for:
|
eboasson
merged commit d7d2578
into
eclipse-cyclonedds:releases/0.10.x
0 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports
As well as #432 to get the CI back to life, though whether that was successful remains to be seen because of #406 and the build not using the correct branch of the
cycloneddsrepository.It also bumps the version number to 0.10.4, I expect that doing a further patch release would appreciated.