1st draft for Python Measurement Writer. #1291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerstinKeller
commented
Jan 10, 2024
| self._protobuf_type = protobuf_type | ||
| self._binary_writer = BinaryChannelWriter(channel_name, meas=meas, encoding = self.encoding, type = self.type, descriptor = self.descriptor) | ||
|
|
||
| def write_entry(self, data, rcv_timestamp: float, snd_timestamp: float): |
There was a problem hiding this comment.
Suggested change
| def write_entry(self, data, rcv_timestamp: float, snd_timestamp: float): | |
| def write_entry(self, data, rcv_timestamp: int, snd_timestamp: int): |
KerstinKeller
commented
Jan 10, 2024
| self._meas.set_channel_description(channel_name, descriptor) | ||
| self._meas.set_channel_type(channel_name, combine_encoding_and_type(encoding, type)) | ||
|
|
||
| def write_entry(self, data, rcv_timestamp: float, snd_timestamp: float): |
There was a problem hiding this comment.
Suggested change
| def write_entry(self, data, rcv_timestamp: float, snd_timestamp: float): | |
| def write_entry(self, data, rcv_timestamp: int, snd_timestamp: int): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add high level API for writing measurements in Python
This was a first draft used in some Python tooling, and I thought it would be useful to bring it to the repo.
However, not yet 100% happy with the API, wouldn't want to make it stable. However the functionality may be valuable.