[measurement] GetChannelDataTypeInformation / SetChannelDataTypeInformation #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of DatatypeInformation as atomic operation.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -177,10 +177,9 @@ bool MeasurementImporter::isEcalMeasFile(const std::string& path) | |||
| return false; | |||
| } | |||
|
|
|||
| bool MeasurementImporter::isProtoChannel(const std::string& channel_type) | |||
| bool MeasurementImporter::isProtoChannel(const eCAL::experimental::measurement::base::DataTypeInformation& channel_info) | |||
There was a problem hiding this comment.
warning: method 'isProtoChannel' can be made static [readability-convert-member-functions-to-static]
app/meas_cutter/src/measurement_importer.h:54:
- bool isProtoChannel(const eCAL::experimental::measurement::base::DataTypeInformation& channel_info);
+ static bool isProtoChannel(const eCAL::experimental::measurement::base::DataTypeInformation& channel_info);| { | ||
| std::string name; //!< name of the datatype | ||
| std::string encoding; //!< encoding of the datatype (e.g. protobuf, flatbuffers, capnproto) | ||
| std::string descriptor; //!< descriptor information of the datatype (necessary for reflection) |
There was a problem hiding this comment.
warning: no type named 'string' in namespace 'std' [clang-diagnostic-error]
std::string descriptor; //!< descriptor information of the datatype (necessary for reflection)
^
contrib/measurement/base/include/ecal/measurement/omeasurement.h
Outdated
Show resolved
Hide resolved
| meas->SetChannelType(channel, eCAL::message::GetTypeName(msg)); | ||
| meas->SetChannelDescription(channel, eCAL::message::GetDescription(msg)); | ||
| eCAL::experimental::measurement::base::DataTypeInformation datatype_info; | ||
| datatype_info.name = eCAL::message::GetTypeName(msg); |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
datatype_info.name = eCAL::message::GetTypeName(msg);
^| meas->SetChannelDescription(channel, eCAL::message::GetDescription(msg)); | ||
| eCAL::experimental::measurement::base::DataTypeInformation datatype_info; | ||
| datatype_info.name = eCAL::message::GetTypeName(msg); | ||
| datatype_info.encoding = eCAL::message::GetEncoding(msg); |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
datatype_info.encoding = eCAL::message::GetEncoding(msg);
^| eCAL::experimental::measurement::base::DataTypeInformation datatype_info; | ||
| datatype_info.name = eCAL::message::GetTypeName(msg); | ||
| datatype_info.encoding = eCAL::message::GetEncoding(msg); | ||
| datatype_info.descriptor = eCAL::message::GetDescription(msg); |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
datatype_info.descriptor = eCAL::message::GetDescription(msg);
^
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rex-schilasky
approved these changes
Feb 13, 2024
| meas->SetChannelType(channel, eCAL::message::GetTypeName(msg)); | ||
| meas->SetChannelDescription(channel, eCAL::message::GetDescription(msg)); | ||
| const eCAL::experimental::measurement::base::DataTypeInformation datatype_info{ | ||
| eCAL::message::GetTypeName(msg), |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
eCAL::message::GetTypeName(msg),
^| meas->SetChannelDescription(channel, eCAL::message::GetDescription(msg)); | ||
| const eCAL::experimental::measurement::base::DataTypeInformation datatype_info{ | ||
| eCAL::message::GetTypeName(msg), | ||
| eCAL::message::GetEncoding(msg), |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
eCAL::message::GetEncoding(msg),
^| const eCAL::experimental::measurement::base::DataTypeInformation datatype_info{ | ||
| eCAL::message::GetTypeName(msg), | ||
| eCAL::message::GetEncoding(msg), | ||
| eCAL::message::GetDescription(msg) |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
eCAL::message::GetDescription(msg)
^
FlorianReimold
pushed a commit
that referenced
this pull request
Feb 16, 2024
…mation (#1349) Provide atomic operations to get and set meta-information related to the channel Co-authored-by: Rex Schilasky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides an API to get/set ChannelDatatypeInformation atomically.
Related issues
#1076
I'd wait for this to be merged until after a branch for 5.13 has been created.
Cherry-Pick to: master-v5