[new-core-alignment] ecal_expmap not using std::iterator anymore #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| using pointer = std::pair<Key, T>*; | ||
| using reference = std::pair<Key, T>&; | ||
|
|
||
| explicit iterator(const typename key_to_value_type::iterator _it) |
There was a problem hiding this comment.
@rex-schilasky how come you made the constructor explicit?
There was a problem hiding this comment.
And what about the iterator tag, is it not necessary?
There was a problem hiding this comment.
@rex-schilasky how come you made the constructor explicit?
https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html
There was a problem hiding this comment.
And what about the iterator tag, is it not necessary?
It's not 100 percent clear to me why you need all 5, it also seems to work with 3 and clang reports 2 of 5 as "unused". But I will complete it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved compatibility of ecal_expmap with C++17.
Cherry-pick to
none