[new-core-alignment] proto file cleanups part 2 (logging) #1361
Conversation
…ible to eCAL5) deprecated ecal/pb API removed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| int inserted_row_count = logging_pb.logs().size(); | ||
| int inserted_row_count = logging_pb.log_messages().size(); |
There was a problem hiding this comment.
warning: variable 'inserted_row_count' of type 'int' can be declared 'const' [misc-const-correctness]
| int inserted_row_count = logging_pb.log_messages().size(); | |
| {const |
| @@ -244,7 +244,7 @@ | |||
| beginInsertRows(QModelIndex(), size_before, size_after - 1); | |||
|
|
|||
| int counter = inserted_row_count; | |||
| for (auto& log_message_pb : logging_pb.logs()) | |||
| for (auto& log_message_pb : logging_pb.log_messages()) | |||
There was a problem hiding this comment.
warning: 'auto &log_message_pb' can be declared as 'const auto &log_message_pb' [readability-qualified-auto]
| for (auto& log_message_pb : logging_pb.log_messages()) | |
| ;const |
| @@ -73,7 +73,7 @@ class LogModel : public QAbstractItemModel | |||
| QModelIndex parent(const QModelIndex &index) const override; | |||
| Qt::ItemFlags flags(const QModelIndex &index) const override; | |||
|
|
|||
| void insertLogs(const eCAL::pb::Logging& logs); | |||
| void insertLogs(const eCAL::pb::LogMessageList& logs); | |||
There was a problem hiding this comment.
warning: function 'LogModel::insertLogs' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
^Additional context
app/mon/mon_gui/src/widgets/models/log_model.cpp:216: the definition seen here
^app/mon/mon_gui/src/widgets/models/log_model.h:75: differing parameters are named here: ('logs'), in definition: ('logging_pb')
^| @@ -113,7 +113,7 @@ class LogModel | |||
| eCAL::Monitoring::GetLogging(raw_data); | |||
| logs.ParseFromString(raw_data); | |||
|
|
|||
| auto &pb_logs = logs.logs(); | |||
| auto &pb_logs = logs.log_messages(); | |||
There was a problem hiding this comment.
warning: 'auto &pb_logs' can be declared as 'const auto &pb_logs' [readability-qualified-auto]
| auto &pb_logs = logs.log_messages(); | |
| const auto &pb_logs = logs.log_messages(); |
| @@ -126,7 +126,7 @@ | |||
| { | |||
| data.erase(data.begin(), data.begin() + overflow_size); | |||
| } | |||
| for(auto &l: logs.logs()) data.push_back(ToLogEntry(l)); | |||
| for(auto &l: logs.log_messages()) data.push_back(ToLogEntry(l)); | |||
There was a problem hiding this comment.
warning: 'auto &l' can be declared as 'const auto &l' [readability-qualified-auto]
| for(auto &l: logs.log_messages()) data.push_back(ToLogEntry(l)); | |
| for(const auto &l: logs.log_messages()) data.push_back(ToLogEntry(l)); |
| @@ -1535,15 +1536,15 @@ PyObject* mon_logging(PyObject* /*self*/, PyObject* /*args*/) | |||
| std::string logging_s; | |||
| if (eCAL::Monitoring::GetLogging(logging_s)) | |||
| { | |||
| eCAL::pb::Logging logging; | |||
| eCAL::pb::LogMessageList logging; | |||
There was a problem hiding this comment.
warning: variable 'logging' of type 'eCAL::pb::LogMessageList' can be declared 'const' [misc-const-correctness]
| eCAL::pb::LogMessageList logging; | |
| eCAL::pb::LogMessageList const logging; |
rex-schilasky
changed the title
rex-schilasky
changed the title
|
|
||
| message LogMessageList // eCAL log message list | ||
| { | ||
| repeated LogMessage log_messages = 1; // log messages |
There was a problem hiding this comment.
Do you need the renaming? It's a bit nicer but not sure if it's strictly necessary.
There was a problem hiding this comment.
But much nicer :-)
Description
Cherry-pick to