[core] core c test added / core cpp test cleaned up #1423
Conversation
core cpp test cleanup
Initialize/Finalize tests removed from pubsub_test (moved to core_test)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <ecal/cimpl/ecal_core_cimpl.h> | ||
| #include <ecal/ecal_defs.h> | ||
|
|
||
| #include <gtest/gtest.h> |
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include <gtest/gtest.h>
^|
|
||
| #include <gtest/gtest.h> | ||
|
|
||
| TEST(core_c, Core_GetVersion) |
There was a problem hiding this comment.
warning: variable 'TEST' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
TEST(core_c, Core_GetVersion)
^| #include <ecal/ecal_core.h> | ||
| #include <ecal/ecal_defs.h> | ||
|
|
||
| #include <gtest/gtest.h> |
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include <gtest/gtest.h>
^|
|
||
| #include <gtest/gtest.h> | ||
|
|
||
| TEST(core_cpp, Core_GetVersion) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST(core_cpp, Core_GetVersion) | |
| TEST(core_cpp /*unused*/, Core_GetVersion /*unused*/) |
| EXPECT_EQ(ECAL_VERSION_PATCH, patch); | ||
| } | ||
|
|
||
| TEST(core_cpp, Core_InitializeFinalize) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST(core_cpp, Core_InitializeFinalize) | |
| TEST(core_cpp /*unused*/, Core_InitializeFinalize /*unused*/) |
| EXPECT_EQ(1, eCAL::Finalize()); | ||
| } | ||
|
|
||
| TEST(core_cpp, Core_MultipleInitializeFinalize) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST(core_cpp, Core_MultipleInitializeFinalize) | |
| TEST(core_cpp /*unused*/, Core_MultipleInitializeFinalize /*unused*/) |
| } | ||
| } | ||
|
|
||
| TEST(core_cpp, Core_UnitName) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST(core_cpp, Core_UnitName) | |
| TEST(core_cpp /*unused*/, Core_UnitName /*unused*/) |
| EXPECT_EQ(0, eCAL::Finalize()); | ||
| } | ||
|
|
||
| TEST(core_cpp, Core_eCAL_Ok) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST(core_cpp, Core_eCAL_Ok) | |
| TEST(core_cpp /*unused*/, Core_eCAL_Ok /*unused*/) |
| { | ||
| // check uninitialized eCAL, should not be okay | ||
| EXPECT_EQ(0, eCAL_Ok()); | ||
|
|
There was a problem hiding this comment.
Nothing to change atm, but it's super counter intuitive, that eCAL_Initialize() returns 0 upon success, but on the other hand eCAL_Ok() returns 0 upon failure, and 1 upon success (e.g. boolean values casted..).
So one behaves like a C style function while the other one doesn't....
Description
eCAL C API is currently not tested. Therefore a core C API test is added and the existing C++ API test is aligned with that.
Cherry-pick to