[core] remove namespace v6, keep v5. Remove build of compatibility ta… #1957
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -401,7 +401,7 @@ namespace eCAL | |||
| return(true); | |||
| } | |||
|
|
|||
| bool CPublisherImpl::SetEventCallback(const v6::PubEventCallbackT callback_) | |||
| bool CPublisherImpl::SetEventCallback(const PubEventCallbackT callback_) | |||
There was a problem hiding this comment.
warning: the const qualified parameter 'callback_' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
ecal/core/src/pubsub/ecal_publisher_impl.h:88:
- bool SetEventCallback(const PubEventCallbackT callback_);
+ bool SetEventCallback(const PubEventCallbackT& callback_);| bool CPublisherImpl::SetEventCallback(const PubEventCallbackT callback_) | |
| bool CPublisherImpl::SetEventCallback(const PubEventCallbackT& callback_) |
| @@ -233,7 +233,7 @@ namespace eCAL | |||
| return(true); | |||
| } | |||
|
|
|||
| bool CSubscriberImpl::SetEventIDCallback(const v6::SubEventCallbackT callback_) | |||
| bool CSubscriberImpl::SetEventIDCallback(const SubEventCallbackT callback_) | |||
There was a problem hiding this comment.
warning: the const qualified parameter 'callback_' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
| bool CSubscriberImpl::SetEventIDCallback(const SubEventCallbackT callback_) | |
| bool CSubscriberImpl::SetEventIDCallback(const SubEventCallbackT& callback_) |
ecal/core/src/pubsub/ecal_subscriber_impl.h:79:
- bool SetEventIDCallback(const SubEventCallbackT callback_);
+ bool SetEventIDCallback(const SubEventCallbackT& callback_);| @@ -95,7 +95,7 @@ namespace eCAL | |||
| Logging::Log(Logging::log_level_debug1, "v5::CServiceClientImpl: Creating service client with name: " + service_name_); | |||
|
|
|||
| // Define the event callback to pass to CServiceClient | |||
| v6::ClientEventCallbackT event_callback = [this](const SServiceId& service_id_, const v6::SClientEventCallbackData& data_) | |||
| eCAL::ClientEventCallbackT event_callback = [this](const SServiceId& service_id_, const eCAL::SClientEventCallbackData& data_) | |||
There was a problem hiding this comment.
warning: variable 'event_callback' of type 'eCAL::ClientEventCallbackT' (aka 'function<void (const SServiceId &, const SClientEventCallbackData &)>') can be declared 'const' [misc-const-correctness]
| eCAL::ClientEventCallbackT event_callback = [this](const SServiceId& service_id_, const eCAL::SClientEventCallbackData& data_) | |
| eCAL::ClientEventCallbackT const event_callback = [this](const SServiceId& service_id_, const eCAL::SClientEventCallbackData& data_) |
| @@ -57,7 +57,7 @@ namespace eCAL | |||
| } | |||
|
|
|||
| // Define the event callback to pass to CServiceClient | |||
| v6::ServerEventCallbackT event_callback = [this](const SServiceId& service_id_, const v6::SServerEventCallbackData& data_) | |||
| eCAL::ServerEventCallbackT event_callback = [this](const SServiceId& service_id_, const eCAL::SServerEventCallbackData& data_) | |||
There was a problem hiding this comment.
warning: variable 'event_callback' of type 'eCAL::ServerEventCallbackT' (aka 'function<void (const SServiceId &, const struct SServerEventCallbackData &)>') can be declared 'const' [misc-const-correctness]
| eCAL::ServerEventCallbackT event_callback = [this](const SServiceId& service_id_, const eCAL::SServerEventCallbackData& data_) | |
| eCAL::ServerEventCallbackT const event_callback = [this](const SServiceId& service_id_, const eCAL::SServerEventCallbackData& data_) |
| /** | ||
| * @brief Service client wrapper class. | ||
| **/ | ||
| class ECAL_API_CLASS CServiceClient |
There was a problem hiding this comment.
warning: variable 'CServiceClient' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
class ECAL_API_CLASS CServiceClient
^| /** | ||
| * @brief Service Server wrapper class. | ||
| **/ | ||
| class ECAL_API_CLASS CServiceServer |
There was a problem hiding this comment.
warning: variable 'CServiceServer' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
class ECAL_API_CLASS CServiceServer
^
| ECAL_CORE_NAMESPACE_V6 | ||
| { | ||
| CServiceClient::CServiceClient(const std::string & service_name_, const ServiceMethodInfoSetT& method_information_set_, const ClientEventCallbackT event_callback_) | ||
| CServiceClient::CServiceClient(const std::string & service_name_, const ServiceMethodInformationSetT& method_information_set_, const ClientEventCallbackT event_callback_) |
There was a problem hiding this comment.
warning: the const qualified parameter 'event_callback_' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
ecal/core/include/ecal/service/client.h:55:
- CServiceClient(const std::string& service_name_, const ServiceMethodInformationSetT& method_information_set_ = ServiceMethodInformationSetT(), const ClientEventCallbackT event_callback_ = ClientEventCallbackT());
+ CServiceClient(const std::string& service_name_, const ServiceMethodInformationSetT& method_information_set_ = ServiceMethodInformationSetT(), const ClientEventCallbackT& event_callback_ = ClientEventCallbackT());| CServiceClient::CServiceClient(const std::string & service_name_, const ServiceMethodInformationSetT& method_information_set_, const ClientEventCallbackT event_callback_) | |
| CServiceClient::CServiceClient(const std::string & service_name_, const ServiceMethodInformationSetT& method_information_set_, const ClientEventCallbackT& event_callback_) |
|
|
||
| private: | ||
| // Private constructor to enforce creation through factory method | ||
| CServiceClientImpl(const std::string& service_name_, const ServiceMethodInfoSetT& method_information_map_, const ClientEventCallbackT& event_callback_); | ||
| CServiceClientImpl(const std::string& service_name_, const ServiceMethodInformationSetT& method_information_map_, const ClientEventCallbackT& event_callback_); |
There was a problem hiding this comment.
warning: function 'eCAL::CServiceClientImpl::CServiceClientImpl' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
CServiceClientImpl(const std::string& service_name_, const ServiceMethodInformationSetT& method_information_map_, const ClientEventCallbackT& event_callback_);
^Additional context
ecal/core/src/service/ecal_service_client_impl.cpp:86: the definition seen here
CServiceClientImpl::CServiceClientImpl(
^ecal/core/src/service/ecal_service_client_impl.h:53: differing parameters are named here: ('method_information_map_'), in definition: ('method_information_set_')
CServiceClientImpl(const std::string& service_name_, const ServiceMethodInformationSetT& method_information_map_, const ClientEventCallbackT& event_callback_);
^
…rget.
Description
Related issues
Cherry-pick to