Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

250-Fix Unable to use passwords with colon #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

250-Fix Unable to use passwords with colon #251

wants to merge 1 commit into from

Conversation

ggam
Copy link
Member

@ggam ggam commented Jun 28, 2019

No description provided.

@ggam ggam marked this pull request as ready for review June 28, 2019 16:50
@ggam ggam mentioned this pull request Jun 28, 2019
Open
@arjantijms arjantijms changed the title Fix 250 250-Fix Unable to use passwords with colon Jun 29, 2019
rdebusscher
rdebusscher requested changes Jun 30, 2019
View reviewed changes
Copy link
Member

@rdebusscher rdebusscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution can be much easier, see comment. Please update PR.

impl/src/main/java/org/glassfish/soteria/mechanisms/BasicAuthenticationMechanism.java Outdated Show resolved Hide resolved
@ggam
Fixes eclipse-ee4j#250
2c21f6e 
Modified test

Signed-off-by: Guillermo González de Agüero <[email protected]>
@cghislai
Copy link
Contributor

@rdebusscher FYI, the requested change had been addressed in the code, although not marked resolved on github it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdebusscher rdebusscher rdebusscher requested changes

@arjantijms arjantijms arjantijms approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggam @cghislai @rdebusscher @arjantijms