Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1036 builder pattern for unix domain socket #2016

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 2, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR builds upon #2015 which needs to be merged first. It adds the builder pattern to UnixDomainSocket and ports the IpcInterface to the builder API. If someone wants to review before the merge of #2015, the easiest way would be to check the last five commits.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff September 2, 2023 09:58
@elBoberido elBoberido mentioned this pull request Sep 2, 2023
21 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #2016 (40b65ae) into master (e70767a) will increase coverage by 0.05%.
Report is 4 commits behind head on master.
The diff coverage is 65.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
+ Coverage   74.17%   74.22%   +0.05%     
==========================================
  Files         415      415              
  Lines       16102    16079      -23     
  Branches     2254     2248       -6     
==========================================
- Hits        11944    11935       -9     
+ Misses       3435     3422      -13     
+ Partials      723      722       -1     
Flag Coverage Δ
unittests 74.01% <65.96%> (+0.04%) ⬆️
unittests_timing 14.96% <31.41%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
iceoryx_dust/source/posix_wrapper/named_pipe.cpp 49.43% <59.70%> (+0.40%) ⬆️
..._hoofs/source/posix_wrapper/unix_domain_socket.cpp 59.75% <63.10%> (+1.00%) ⬆️
...clude/iceoryx_dust/posix_wrapper/message_queue.hpp 100.00% <100.00%> (ø)
.../include/iceoryx_dust/posix_wrapper/named_pipe.hpp 100.00% <100.00%> (ø)
...ceoryx_dust/source/posix_wrapper/message_queue.cpp 61.90% <100.00%> (-1.37%) ⬇️
...oofs/internal/posix_wrapper/unix_domain_socket.hpp 100.00% <100.00%> (ø)
iceoryx_posh/source/runtime/ipc_interface_base.cpp 64.15% <100.00%> (+1.40%) ⬆️

... and 2 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-1036-builder-pattern-for-unix-domain-socket branch from daa1737 to 40b65ae Compare September 4, 2023 14:27
@elBoberido elBoberido marked this pull request as ready for review September 4, 2023 14:28
@elBoberido elBoberido self-assigned this Sep 4, 2023
@elBoberido elBoberido added refactoring Refactor code without adding features technical debt unclean code and design flaws labels Sep 4, 2023
@elBoberido elBoberido merged commit f434f6f into eclipse-iceoryx:master Sep 4, 2023
18 checks passed
@elBoberido elBoberido deleted the iox-1036-builder-pattern-for-unix-domain-socket branch September 4, 2023 18:37
@elBoberido elBoberido linked an issue Sep 4, 2023 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove creation design pattern class with in place implementation
3 participants