-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1036 builder pattern for unix domain socket #2016
Merged
elBoberido
merged 5 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1036-builder-pattern-for-unix-domain-socket
Sep 4, 2023
Merged
iox-#1036 builder pattern for unix domain socket #2016
elBoberido
merged 5 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1036-builder-pattern-for-unix-domain-socket
Sep 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
elBoberido
commented
Sep 2, 2023
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/unix_domain_socket.hpp
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
+ Coverage 74.17% 74.22% +0.05%
==========================================
Files 415 415
Lines 16102 16079 -23
Branches 2254 2248 -6
==========================================
- Hits 11944 11935 -9
+ Misses 3435 3422 -13
+ Partials 723 722 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elBoberido
force-pushed
the
iox-1036-builder-pattern-for-unix-domain-socket
branch
from
September 4, 2023 14:27
daa1737
to
40b65ae
Compare
elBoberido
added
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
labels
Sep 4, 2023
elfenpiff
reviewed
Sep 4, 2023
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/unix_domain_socket.hpp
Show resolved
Hide resolved
elfenpiff
approved these changes
Sep 4, 2023
FerdinandSpitzschnueffler
approved these changes
Sep 4, 2023
elBoberido
deleted the
iox-1036-builder-pattern-for-unix-domain-socket
branch
September 4, 2023 18:37
12 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR builds upon #2015 which needs to be merged first. It adds the builder pattern to
UnixDomainSocket
and ports theIpcInterface
to the builder API. If someone wants to review before the merge of #2015, the easiest way would be to check the last five commits.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References