-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2377: Include <chrono>
for system_clock
#2378
base: main
Are you sure you want to change the base?
Conversation
Pinging @elfenpiff ... I have signed the ECA, but I don't know why this PR show failed with the ECA check. Please let me know what I should do about this. Thanks in advance. |
It might take a day until everything is synced. If the ECA still fails tomorrow, we need to investigate further. As long as your commit have the same email address as set in the ECA, it should work once the servers are synced. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
- Coverage 78.70% 78.69% -0.01%
==========================================
Files 440 440
Lines 16981 16981
Branches 2361 2361
==========================================
- Hits 13365 13364 -1
Misses 2736 2736
- Partials 880 881 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@LilyWangLL I restarted multiple times the ECA verification check and then checked to commit author:
You must use the same email address for signing the ECA and for every commit and You should be able to adjust the author by calling:
|
Thanks for your reply. I have updated this. |
Notes for Reviewer
I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in
iceoryx
. It must add include<chrono>
to fix this error.Compiler error with this STL change:
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References