-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment of Default Class Implementations to Interface definitions #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Most of the changes look good to me.
However, I'm not convinced of these:
- Implemented default no-op implementations for several DocumentUpdateHandler methods to reduce boilerplate in subclasses.
- Refactored several methods to use optional parameters with default values instead of explicitly passing default values, improving code readability.
…ons for optional methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor changes, see below.
Co-authored-by: Mark Sujew <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 👍
Resolves #1584
Summary: