Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize document sorting and update documentation #1605

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

snarkipus
Copy link
Contributor

  • Optimized the sortDocuments method in DefaultDocumentBuilder class, replacing the previous sort algorithm with a more efficient in-place partitioning approach (non-stable) to separate documents with and without associated text documents
  • Updated documentation

Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change looks good, just two remarks below.

packages/langium/src/references/scope-computation.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spoenemann spoenemann merged commit d122afc into eclipse-langium:main Aug 2, 2024
4 checks passed
@spoenemann spoenemann added this to the v3.2.0 milestone Aug 2, 2024
@snarkipus snarkipus deleted the sort-optimize branch August 2, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants