Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Testing of charts #92

Merged
merged 6 commits into from
Nov 22, 2023
Merged

fix: Testing of charts #92

merged 6 commits into from
Nov 22, 2023

Conversation

adkumar1
Copy link
Contributor

@adkumar1 adkumar1 commented Nov 22, 2023 •
edited
Loading

@adkumar1 adkumar1 mentioned this pull request Nov 22, 2023
Closed
@adkumar1
Copy link
Contributor Author

@adityagajbhiye : Please review

@SebastianBezold
Copy link
Contributor

Hi @adkumar1,

can you please also provide some details on this PR about the linting issue? It's not really visible, which of the changes fixes the lint part. Also, the PR seems to include changes that are unrelated to Chart linting. Please remove them from the PR

@adkumar1
Copy link
Contributor Author

adkumar1 commented Nov 22, 2023 •
edited
Loading

Hi,
Actually workflow was failing in test connection.
I think below file is not mandatorily required which is applicable for test-connection. So this has been removed.
charts/orchestrator/templates/tests/test-connection.yaml

adityagajbhiye9
adityagajbhiye9 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint changes looks ok.

@SebastianBezold
Copy link
Contributor

Hi, Actually workflow was failing in test connection. I think below file is not mandatorily required which is applicable for test-connection. So this has been removed. charts/orchestrator/templates/tests/test-connection.yaml

So this is not at all about linting, but testing. Could you please adjust this in your PR title?

@adkumar1 adkumar1 changed the title fix: Linting of charts fix: Testing of charts Nov 22, 2023
@adkumar1
Copy link
Contributor Author

Hi, Actually workflow was failing in test connection. I think below file is not mandatorily required which is applicable for test-connection. So this has been removed. charts/orchestrator/templates/tests/test-connection.yaml

So this is not at all about linting, but testing. Could you please adjust this in your PR title?

Updated the title

@SebastianBezold SebastianBezold merged commit 19e95c5 into eclipse-tractusx:main Nov 22, 2023
3 checks passed
@SebastianBezold SebastianBezold deleted the lint-fix branch November 22, 2023 10:22
@SebastianBezold SebastianBezold mentioned this pull request Nov 22, 2023
Closed
@sachinargade123 sachinargade123 restored the lint-fix branch November 22, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@SebastianBezold SebastianBezold SebastianBezold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm test workflow failing
4 participants
@adkumar1 @SebastianBezold @adityagajbhiye9 @sachinargade123