Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POSIX target for small posix based RTOS's i.e. NuttX #194

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

PetervdPerk-NXP
Copy link
Contributor

Adds POSIX_COMPATIBLE CMake variable so that any POSIX compatible operating system i.e. NuttX can include Zenoh-pico as a module in their CMake build system.

Furthermore this adds a define UNIX_NO_MULTICAST_IF to disable the IP_MULTICAST_IF socketoption which isn't supported in NuttX.

@gabrik gabrik requested a review from cguimaraes April 5, 2023 15:56
@PetervdPerk-NXP PetervdPerk-NXP force-pushed the cmake_posix_target branch 3 times, most recently from ef41809 to 9964d6a Compare April 25, 2023 08:26
@PetervdPerk-NXP
Copy link
Contributor Author

@cguimaraes I've updated the PR could you launch the CI to make sure all targets can build with this change?

@Mallets
Copy link
Member

Mallets commented Apr 25, 2023

@cguimaraes I've updated the PR could you launch the CI to make sure all targets can build with this change?

CI kicked

@cguimaraes
Copy link
Member

Thank you @PetervdPerk-NXP .
We have a release coming out in the upcoming weeks, to which we have already freeze the set of features.

This is the reason why this PR has not been merged yet. That will happen immediately after the release and will be part of the one after.

@PetervdPerk-NXP
Copy link
Contributor Author

Now that's 0.7.2.0 is out, any blocker to merge this?

Copy link
Member

@cguimaraes cguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cguimaraes
Copy link
Member

To be merged after #222 .

@cguimaraes
Copy link
Member

Closing and reopen the PR to force CI to run again with the latest master changes.

@cguimaraes cguimaraes closed this Jul 26, 2023
@cguimaraes cguimaraes reopened this Jul 26, 2023
@cguimaraes cguimaraes merged commit 37397bf into eclipse-zenoh:master Jul 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants