Fix (C++) build for windows #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'documentation', 'new feature', 'enhancement', 'breaking-change', 'dependencies', 'bug', 'internal'} |
This was referenced Sep 17, 2024
jean-roland
reviewed
Sep 18, 2024
include/zenoh-pico/config.h
Outdated
| @@ -21,7 +21,7 @@ | |||
| #define Z_BATCH_MULTICAST_SIZE 2048 | |||
| #define Z_CONFIG_SOCKET_TIMEOUT 100 | |||
|
|
|||
| #define Z_FEATURE_UNSTABLE_API 0 | |||
| #define Z_FEATURE_UNSTABLE_API 1 | |||
There was a problem hiding this comment.
I'd revert this value as PIO doesn't seem to autogenerate this file properly for now. Otherwise, LGTM
jean-roland
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix C++ build for windows:
Enable shared libs build for windows;
rename asm stub argument from "asm" to "instruction" since asm is reserved keyword;
force exporting all symbols for dll (TODO: mark only public api for export);
replace _Bool with bool, since the later is supported starting from C99 (_Bool is not supported in C++ under windows)