Encapsulate flume::Receiver
#1504
Merged
+320
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
added
enhancement
fuzzypixelz
force-pushed
the
hide-flume
branch
from
c39b25e
to
4ea19ea
Compare
fuzzypixelz
force-pushed
the
hide-flume
branch
from
4ea19ea
to
fd4a652
Compare
gabrik
approved these changes
Oct 3, 2024
|
The CI is not happy yet :D |
This was marked as unused after fd4a652
This was referenced Oct 8, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entirety of
flume::Receiver's API was exposed to anyone who declared subscribers with the default handler (which at least one person, myself). This is arguably not good:flumecould break semver (it seems to be a cool crate but mistakes can happen and you can never be too careful)flumealways respects semver, we can't update it from 0.11 to a semver-incompatible version without break thezenohAPI.FifoChannel::Handlerif a new faster channel comes around.