Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype of so-only wheel #152

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

prototype of so-only wheel #152

wants to merge 8 commits into from

Conversation

tmi
Copy link

@tmi tmi commented Nov 25, 2024

This is a minimalistic prototype of building a trivial wheel with .so's only, to be used by subsequent wheels

It consists of:

  • Dockerfile, dockerbuild.sh and buildscripts -- those should actually go to another repo (which one tho?), as these would be reused by all compiled projects.
    • the Dockerfile mainly just installs flex and bison and ecbuild, and copies the buildscripts
    • the buildscripts/{compile.sh, wheel-linux.sh, test-wheel.sh} invoke the respective parts of the wheel building -- see the github action for the sequencing
  • the setup.cfg and buildconfig, which is the eckit-specific parts for the wheel building. This would presumably grow as we'd be wheelifying more complicated projects later (eg, build more components, more config options, more prereqs, ...)

@FussyDuck
Copy link

FussyDuck commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.74%. Comparing base (9d2807d) to head (9e548b2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #152   +/-   ##
========================================
  Coverage    63.74%   63.74%           
========================================
  Files         1066     1066           
  Lines        55360    55360           
  Branches      4086     4086           
========================================
  Hits         35289    35289           
  Misses       20071    20071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmi tmi force-pushed the project/wheelify branch from d51e71e to 736760f Compare December 9, 2024 15:48
@tmi tmi marked this pull request as ready for review December 9, 2024 15:53
@tmi tmi force-pushed the project/wheelify branch 20 times, most recently from 00af3d0 to aac2a37 Compare December 10, 2024 14:06
@tmi tmi force-pushed the project/wheelify branch 5 times, most recently from 0702997 to df92180 Compare December 12, 2024 11:00
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12295382036.

@tmi tmi force-pushed the project/wheelify branch 13 times, most recently from a631ee1 to fbb09cc Compare December 12, 2024 12:28
@tmi tmi force-pushed the project/wheelify branch from fbb09cc to 381e6ae Compare December 12, 2024 12:33
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12296863645.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12297549124.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12353224995.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12353393231.

3 similar comments
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12353393231.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12353393231.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12353393231.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants