Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration tests for users api AP-1239 #275

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat: add integration tests for users api AP-1239 #275

merged 3 commits into from
Sep 18, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Aug 19, 2024 •
edited
Loading

Description

This PR adds an integration test for the users' API. This test is executed in the job of Tutor Integration Tests

Testing instructions

Check the jobs of Tutor Integration Tests in the PR.

Additional Information

The Palm Release (<17.0.0) was removed from the integration tests workflow.

Jira Issue

@github-actions github-actions bot added size/m and removed size/xs labels Aug 19, 2024
@BryanttV BryanttV force-pushed the bav/add-integration-tests branch 3 times, most recently from b4191f3 to eb8122b Compare August 21, 2024 00:09
@BryanttV BryanttV changed the title chore: add integration tests chore: add integration tests for users api Aug 21, 2024
@BryanttV BryanttV changed the title chore: add integration tests for users api chore: add integration tests for users api AP-1239 Aug 21, 2024
@BryanttV BryanttV force-pushed the bav/add-integration-tests branch 2 times, most recently from 2d98bf1 to 09781d7 Compare August 21, 2024 21:21
@BryanttV BryanttV marked this pull request as ready for review August 23, 2024 17:28
@BryanttV BryanttV changed the title chore: add integration tests for users api AP-1239 feat: add integration tests for users api AP-1239 Aug 23, 2024
@BryanttV BryanttV requested a review from a team August 23, 2024 17:34
bra-i-am
bra-i-am reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @BryanttV, thanks for this. I only have a little comment, everything else looks good to me. After your answer, I'll give the approval

eox_core/tests/tutor/integration_test_users.py Outdated Show resolved Hide resolved
@bra-i-am bra-i-am requested a review from a team August 27, 2024 14:07
@BryanttV BryanttV requested a review from bra-i-am August 28, 2024 15:51
bra-i-am
bra-i-am previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BryanttV BryanttV force-pushed the bav/add-integration-tests branch 2 times, most recently from 638c450 to b351cd4 Compare August 30, 2024 15:31
@BryanttV BryanttV requested a review from a team August 30, 2024 20:02
dcoa
dcoa previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryanttV BryanttV force-pushed the bav/add-integration-tests branch 3 times, most recently from df3b7eb to bf6cf4b Compare September 6, 2024 21:22
@magajh magajh self-requested a review September 9, 2024 15:24
@github-actions github-actions bot added size/l and removed size/m labels Sep 9, 2024
@BryanttV BryanttV added size/l and removed size/xl labels Sep 17, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Sep 17, 2024
@BryanttV BryanttV changed the base branch from master to bav/move-unit-tests September 17, 2024 22:21
@github-actions github-actions bot added size/l and removed size/xl labels Sep 17, 2024
@BryanttV
Copy link
Contributor Author

Hi @magajh @mariajgrimaldi. I had to create a new PR because this one was too long according to the label workflow. We should merge this one first: #279

magajh
magajh previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@magajh magajh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BryanttV
LGTM

mariajgrimaldi
mariajgrimaldi previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@BryanttV BryanttV changed the base branch from bav/move-unit-tests to master September 18, 2024 13:23
@BryanttV BryanttV dismissed stale reviews from mariajgrimaldi and magajh September 18, 2024 13:23

The base branch was changed.

@BryanttV BryanttV merged commit 9143370 into master Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magajh magajh magajh approved these changes

@dcoa dcoa dcoa left review comments

@bra-i-am bra-i-am bra-i-am left review comments

@mariajgrimaldi mariajgrimaldi Awaiting requested review from mariajgrimaldi

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BryanttV @magajh @mariajgrimaldi @dcoa @bra-i-am