feat: add national_id validation for reference_id #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
django_plugin
test
size/m
andrey-canon
requested changes
Aug 16, 2023
johanseto
force-pushed
the
jlc/update-certificates-referenceid
branch
2 times, most recently
from
88ba287
to
985c470
Compare
|
andrey-canon
requested changes
Aug 16, 2023
| @@ -120,9 +126,131 @@ def test_invalid_group_codes(self, generate_certificate_mock, passing_mock): | |||
| certificate.id = 85 | |||
| generate_certificate_mock.objects.get.return_value = certificate | |||
| passing_mock.return_value = True | |||
| data = { | |||
| external_certificate_data = { | |||
There was a problem hiding this comment.
indeed the external certificate data is the output of _generate_external_certificate_data, anyways neither adds nor subtracts.
There was a problem hiding this comment.
Pylint throws me an error when I add the decorator data. That is the reason I had to rename there.
https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/redefined-outer-name.html
eox-nelp/eox_nelp/signals/tests/test_utils.py
Line 139 in 985c470
But actually I thing I changed more xD
eox_nelp/signals/utils.py
Outdated
|
|
||
| def generate_reference_id(national_id, course_id): | ||
| """Generate string of reference_id shape. | ||
| username<string>: Username of the user(national_id). |
andrey-canon
approved these changes
Aug 16, 2023
Also the shape of reference_id was updated adding the course_id.
`{national_id}~{course_id}"`
feat: saml extra association filter
With this change we ensure to send certificates if the user was created with a saml extra
association that add more sufix data different than current username. So this ensure the national_id
have to be processed with the 10 first chars.
chore: style suggestions from code review
Co-authored-by: Andrey Cañon <[email protected]>
chore: style recommendations
johanseto
force-pushed
the
jlc/update-certificates-referenceid
branch
from
b22763b
to
ab05dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add national_id validation for reference_id
Also, the shape of reference_id was updated adding the course_id.
{username}~{course_id}"Testing instructions
Tested in stage debug server.
After
wrong username national id
correct username national id
Additional information
Main jira story parent
https://edunext.atlassian.net/browse/FUTUREX-471
Checklist for Merge