refactor: inherit from social auth exception #192
Conversation
johanseto
force-pushed
the
jlc/refactor-tpa-exception
branch
from
a7d8f27
to
bdbe939
Compare
|
@andrey-canon For the test failing I made this PR to eox-tenant. But yes I can added also to this branch in other PR. |
|
@andrey-canon for the inclusion of the requirements. I avoid it because I want this PR to have the lowest lines and lowest impact. |
in the past this was consider as the lazy way to pass the test if you are worried about the number of lines my suggestion is to do |
|
This change the heritance of the eox-tenant-auth-exception. This with the purpose of the exception to be handled by the social tpa middleware exception process. You can see here that the new class is also based in value error exception. https://github.com/python-social-auth/social-core/blob/29cbbd22b98d81d569a886b1cc0bd9a316cd124f/social_core/exceptions.py#L1 But the change is related with this PR: eduNEXT/eox-core#171 So now as the exception is family of the SocialAuthBaseException. The the tpa middleware could managed it. https://github.com/python-social-auth/social-app-django/blob/5.4.0/social_django/middleware.py#L35 Keep in mind that this middleware is parent of edx-platform middleware. https://github.com/openedx/edx-platform/blob/ebcbe1cd9208191c0589d7fe538c6ac13470abe6/common/djangoapps/third_party_auth/middleware.py#L18
johanseto
force-pushed
the
jlc/refactor-tpa-exception
branch
from
4961cef
to
b306762
Compare
|
@andrey-canon I have added the dependency. |
|
@johanseto could you open the PR against master, please |
|
PR opened against master |
Description
This changes the inheritance of the eox-tenant-auth-exception.
This is with the purpose of the exception to be handled by the social tpa middleware exception process.
This is to avoid this 502 error msg:
You can see here that the new inheritance class is also based on value error exception.
But the change is related to this eox-core PR:
So now the exception is family of the SocialAuthBaseException.
With that change now, the social_django middleware could manage it.
Keep in mind that this middleware is the parent of edx-platform middleware.
The middleware seems applied in the openedx tpa module.
Checklist for Merge