refactor: inherit from social auth exception #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
johanseto
force-pushed
the
jlc/refactor-tpa-exception-social-core
branch
from
0329324
to
ac07a9a
Compare
|
I am only adding social-auth-core in base.in eox-tenant/requirements/base.in Line 12 in 9c22abd and the running make upgrade.
For some unknown reason I had to change the |
johanseto
force-pushed
the
jlc/refactor-tpa-exception-social-core
branch
2 times, most recently
from
653cfe7
to
3806aaa
Compare
|
hi @johanseto, I hope you're well... could you please solve the conflicts to start with this PR's review? Thank you :D |
* refactor: inherit from social auth exception This change the heritance of the eox-tenant-auth-exception. This with the purpose of the exception to be handled by the social tpa middleware exception process. You can see here that the new class is also based in value error exception. https://github.com/python-social-auth/social-core/blob/29cbbd22b98d81d569a886b1cc0bd9a316cd124f/social_core/exceptions.py#L1 But the change is related with this PR: eduNEXT/eox-core#171 So now as the exception is family of the SocialAuthBaseException. The the tpa middleware could managed it. https://github.com/python-social-auth/social-app-django/blob/5.4.0/social_django/middleware.py#L35 Keep in mind that this middleware is parent of edx-platform middleware. https://github.com/openedx/edx-platform/blob/ebcbe1cd9208191c0589d7fe538c6ac13470abe6/common/djangoapps/third_party_auth/middleware.py#L18 * refactor: social-auth-core pkg inclusion (cherry picked from commit c542749) chore: run make upgrade
johanseto
force-pushed
the
jlc/refactor-tpa-exception-social-core
branch
3 times, most recently
from
80af81d
to
f0fc85a
Compare
add use-yield-from (R1737) due pylint update to 3.1.0
johanseto
force-pushed
the
jlc/refactor-tpa-exception-social-core
branch
from
f0fc85a
to
b6301d9
Compare
|
@bra-i-am nice confliicts resolved, I had to update a rule to the pyint disable due the update of plint and some yield config that is not under the scope of this PR. |
MaferMazu
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change the heritance of the eox-tenant-auth-exception.
This with the purpose of the exception to be handled by the social tpa middleware exception process.
You can see here that the new class is also based in value error exception. https://github.com/python-social-auth/social-core/blob/29cbbd22b98d81d569a886b1cc0bd9a316cd124f/social_core/exceptions.py#L1
But the change is related with this PR:
eduNEXT/eox-core#171
So now as the exception is family of the SocialAuthBaseException.
The the tpa middleware could managed it.
https://github.com/python-social-auth/social-app-django/blob/5.4.0/social_django/middleware.py#L35
Keep in mind that this middleware is parent of edx-platform middleware. https://github.com/openedx/edx-platform/blob/ebcbe1cd9208191c0589d7fe538c6ac13470abe6/common/djangoapps/third_party_auth/middleware.py#L18
(cherry picked from commit c542749)
Additional information
Please before review or approve the commitlint-PR or I can't add links or urls in the commits body.
PR related the change:
#192
Checklist for Merge