feat: Robustness improvements to datadog_diagnostics plugin #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `DATADOG_DIAGNOSTICS_ENABLE` for quick disable if needed - Limit spans with `DATADOG_DIAGNOSTICS_MAX_SPANS` (default 100) - Fix scope of member variables - Add unit tests Manual testing: - Modify `common.djangoapps.student.views.dashboard.student_dashboard` in edx-platform to call `import time; time.sleep(10)` at the start of the view. - Start server and log - Visit /dashboard - While the browser is waiting, quickly make a small edit to an edx-platform file, causing an autoreload. - Confirm that spans are logged.
dianakhuang
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATADOG_DIAGNOSTICS_ENABLEfor quick disable if neededDATADOG_DIAGNOSTICS_MAX_SPANS(default 100)Manual testing:
common.djangoapps.student.views.dashboard.student_dashboardin edx-platform to callimport time; time.sleep(10)at the start of the view.Merge checklist:
Check off if complete or not applicable: